Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #21 by having more informative error message when deleting a custom scorer #22

Merged
merged 6 commits into from
Nov 8, 2019

Conversation

epugh
Copy link
Member

@epugh epugh commented Nov 8, 2019

Description

I need to delete a custom scorer, but it is tied to other users, cases, or qeuries, but I don't know which. So let me know.

Motivation and Context

Fixeds #21

How Has This Been Tested?

Ran unit tests.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh requested a review from worleydl November 8, 2019 19:15
@epugh
Copy link
Member Author

epugh commented Nov 8, 2019

@worleydl gives thumbs up

@epugh epugh merged commit b3791bf into master Nov 8, 2019
@nathancday nathancday deleted the feature-21-more-informative-error-message-on-scorer branch March 13, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant