Restore proper support for notifying users about Cookies being required policy #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cookie logic no longer worked, and was only run on the cases page. The links to the cookie policy didn't render either.
If you want to hide permannetnly, then hit okay.
|
Don't forget to make it all conditional on the cookies url being populated. Update the docs too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie logic no longer worked, and was only run on the cases page. The links to the cookie policy didn't render either.
Description
The popup for saying we need cookie support would happen, but never be stored. The logic only ran on the core pages, not the homepage. So you just got the popup over and over and over.
Motivation and Context
Be less annonying! And have it show up on the logical page, the homepage!