Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Rails 8 #1084

Merged
merged 37 commits into from
Nov 6, 2024
Merged

Migration to Rails 8 #1084

merged 37 commits into from
Nov 6, 2024

Conversation

epugh
Copy link
Member

@epugh epugh commented Oct 28, 2024

Description

Introduce solid cable as first step to removing redis. Next will be be solid job.

Motivation and Context

Simplify deployment. For example, a client has to build terraform for Quepid, and they need quepid, mysql AND redis. Let's remove redis. Plus cost.

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh changed the title Being migration to Rails 8 Migration to Rails 8 Oct 28, 2024
@epugh
Copy link
Member Author

epugh commented Nov 1, 2024

@ychaker I hate that I have to manually track the status of long running jobs myself.... See 396c0a6 for the fact I had to build this myself. ActiveStorage lets me say "hey book, do you have a file attached", but in the ActiveJob world I can't say "Hey book, do you have an export job queued or running"? Very annoying....

@epugh
Copy link
Member Author

epugh commented Nov 1, 2024

@reid-rigo See 396c0a6 for what I ended up with. I couldn't get json to work super nice, annoying t deal with nils etc.. Having said that, I can imagine that i may want to track more data in hte future, maybe specific to a type of job, and then i move towards json data strucutre? Or, just more activerecord objects and tables?

Use the pages_controller, and some magic intercepting to make
@epugh
Copy link
Member Author

epugh commented Nov 6, 2024

I gave up on removing Sprockets... Instead I updated the various Gems to work with Rails 8. Sign....

@epugh epugh temporarily deployed to quepid-pr-1084 November 6, 2024 19:43 Inactive
@epugh epugh merged commit 22cceb2 into main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant