Skip to content

Commit

Permalink
Final clean up from introducing the search_endpoint concept
Browse files Browse the repository at this point in the history
  • Loading branch information
epugh committed Jan 22, 2024
1 parent db03359 commit f06c1bd
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 17 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

# Quepid

[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
Expand Down
4 changes: 0 additions & 4 deletions app/models/try.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@
#
# id :integer not null, primary key
# ancestry :string(3072)
# api_method :string(255)
# custom_headers :string(1000)
# escape_query :boolean default(TRUE)
# field_spec :string(500)
# name :string(50)
# number_of_rows :integer default(10)
# query_params :string(20000)
# search_engine :string(50) default("solr")
# search_url :string(500)
# try_number :integer
# created_at :datetime not null
# updated_at :datetime not null
Expand Down
11 changes: 11 additions & 0 deletions db/migrate/20240122154641_drop_extra_try_fields.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
class DropExtraTryFields < ActiveRecord::Migration[7.1]
# we left the fields on Try when we introduced Search Endpoints
# in case we needed to rollback. However, we can now do the
# cleanup!
def change
remove_column :tries, :api_method
remove_column :tries, :custom_headers
remove_column :tries, :search_engine
remove_column :tries, :search_url
end
end
6 changes: 1 addition & 5 deletions db/schema.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified docs/erd.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 0 additions & 4 deletions test/fixtures/tries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@
#
# id :integer not null, primary key
# ancestry :string(3072)
# api_method :string(255)
# custom_headers :string(1000)
# escape_query :boolean default(TRUE)
# field_spec :string(500)
# name :string(50)
# number_of_rows :integer default(10)
# query_params :string(20000)
# search_engine :string(50) default("solr")
# search_url :string(500)
# try_number :integer
# created_at :datetime not null
# updated_at :datetime not null
Expand Down
4 changes: 0 additions & 4 deletions test/models/try_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@
#
# id :integer not null, primary key
# ancestry :string(3072)
# api_method :string(255)
# custom_headers :string(1000)
# escape_query :boolean default(TRUE)
# field_spec :string(500)
# name :string(50)
# number_of_rows :integer default(10)
# query_params :string(20000)
# search_engine :string(50) default("solr")
# search_url :string(500)
# try_number :integer
# created_at :datetime not null
# updated_at :datetime not null
Expand Down

0 comments on commit f06c1bd

Please sign in to comment.