Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a timestamp on events when no timestamp value is provided #70

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Setting a timestamp on events when no timestamp value is provided #70

merged 1 commit into from
Feb 27, 2024

Conversation

jzonthemtn
Copy link
Collaborator

Setting a timestamp on events when no timestamp value is provided for #62.

epugh
epugh approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. Test for the with and without pattern of timestamping?

@RasonJ
Copy link
Collaborator

RasonJ commented Feb 27, 2024

I'm leaning towards never letting the client set the timestamp manually. What do you think of two timestamps? a server time and a client time?

@jzonthemtn
Copy link
Collaborator Author

@epugh Unit tests are coming. There is a branch where Java tests are a work in progress. The yaml REST tests need updated for all possible request types.

@epugh epugh merged commit 330f911 into main Feb 27, 2024
1 check passed
@jzonthemtn jzonthemtn deleted the timestamps branch March 14, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

@RasonJ RasonJ RasonJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzonthemtn @RasonJ @epugh