Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize over field variable type #861

Merged
merged 14 commits into from
Jan 8, 2025
Merged

Generalize over field variable type #861

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b243a1f
Remove redundant functor
mrmr1993 Jan 2, 2025
9151622
Use field and field_var from Types module
mrmr1993 Jan 2, 2025
4f954e9
Remove use of Cvar.t constructors
mrmr1993 Jan 2, 2025
2d40946
Hoist generalized functions
mrmr1993 Jan 6, 2025
5676db4
Hoist Cvar_intf
mrmr1993 Jan 6, 2025
b1997ff
Include Cvar in Backend_intf
mrmr1993 Jan 6, 2025
4a7dff5
Explicitly use Cvar.t for field_var alias
mrmr1993 Jan 6, 2025
918ed8a
Relax As_prover0 interface
mrmr1993 Jan 6, 2025
573a7b3
Use Backend.Cvar methods in Utils
mrmr1993 Jan 6, 2025
53232ba
Use Cvar helper functions instead of constructors in Snark0
mrmr1993 Jan 6, 2025
c3b1c46
Move misplaced comment
mrmr1993 Jan 6, 2025
b9f1a2c
Introduce field_var in Snark_intf
mrmr1993 Jan 6, 2025
a608ed9
Generalize over field_var type
mrmr1993 Jan 7, 2025
010a954
Merge branch 'master' into feature/generalize-cvar
mrmr1993 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base/snark_intf.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,9 @@ end
module type Field_var_intf = sig
type field

(** The type that stores booleans as R1CS variables. *)
Copy link
Member

@dannywillems dannywillems Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. You're reading the documentation now? 😮

type boolean_var

(** The type that stores booleans as R1CS variables. *)
type t = field Cvar.t

(** For debug purposes *)
Expand Down