Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: extra format string compiler security flags #503

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add: extra format string compiler security flags #503

merged 1 commit into from
Feb 18, 2025

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Feb 17, 2025

Description

  • added additional security flags to treat potential format string vulnerabilities as errors:
    • GCC/Clang: -Werror=format-security
    • MSVC: /we4477 /we4473

Testing

  • Windows 11 AMD64
  • Linux Debian 12 AMD64

@dnzbk dnzbk requested review from phnzb and luckedea February 17, 2025 07:11
@dnzbk dnzbk linked an issue Feb 17, 2025 that may be closed by this pull request
Allow Compiling With -Werror=format-security #502
Closed
@dnzbk dnzbk merged commit 4ffcb04 into develop Feb 18, 2025
19 checks passed
@dnzbk dnzbk deleted the str-format-security-flags branch February 18, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckedea luckedea luckedea approved these changes

@phnzb phnzb Awaiting requested review from phnzb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Compiling With -Werror=format-security
2 participants
@dnzbk @luckedea