Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix loading icon display for NZB uploads in light and dark mode #486

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

pjotrvdh
Copy link
Contributor

@pjotrvdh pjotrvdh commented Jan 4, 2025

While using dark mode I've noticed that the loading gif used with uploading NZB files was not optimized for use with dark backgrounds. I've replaced this image with one of the available icons from the material icon set and updated the javascript accordingly.

@pjotrvdh pjotrvdh marked this pull request as draft January 4, 2025 17:18
@pjotrvdh pjotrvdh marked this pull request as ready for review January 4, 2025 17:18
@dnzbk dnzbk self-assigned this Jan 4, 2025
@dnzbk dnzbk self-requested a review January 5, 2025 06:10
@dnzbk dnzbk removed their assignment Jan 5, 2025
Copy link
Collaborator

@dnzbk dnzbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dnzbk dnzbk merged commit e1d6f69 into nzbgetcom:develop Jan 6, 2025
3 checks passed
@dnzbk dnzbk mentioned this pull request Feb 24, 2025
dnzbk added a commit that referenced this pull request Feb 24, 2025
## Description
  - Features:
    - Improved deobfuscation [#469](#469)
      - enhanced parsing of the subject field in NZB files and improved validation of downloaded article filenames 
      - added a check for filename obfuscation after unpacking; excessively obfuscated filenames are renamed to the NZB filename 
      - added new options:
        - `RenameAfterUnpack` - enables/disables renaming of extracted and obfuscated files using the NZB filename
        - `RenameIgnoreExt` - a comma-separated list of file extensions to ignore when renaming files after unpacking
      - added a new value for the `Status` field in the `listgroups` API method: `POST_UNPACK_RENAMING`
    - Network speed tests
      - the new API-method:
        - `struct testnetworkspeed()` - returns the measured network speed in `Mbps` [#489](#489)
    - Added support by `DirectRename` and `ParRename` of nested file paths found in par files [#497](#497)
    - Added a filter to the nzb manual upload dialog [#505](#505)
  - Bug fixes:
    - Fixed: `HealthCheck=None` with `ParCheck=Force` can cause a segmentation fault on unhealthy downloads [#475](#475)
    - Fixed: Attempting to load the certificate even if CertCheck is turned off [#479](#479)
    - Fixed: Loading icon display for NZB uploads in light and dark modes [#486](#486)
    - Fixed PowerPC (ppc500) support [#491](#491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants