This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fix/dated show name #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The series name specifiers %sn, %s.b, %s_n and %sN, %s.N, %s_N were based on buggy code from MoviesFormat. The new implementation is based on the correctly working SeriesFormat code and proper test cases were added. See: nzbget#52
Since the %desc is not supported by guessit, it would always be empty. Furthermore no documentation was provided and all dated test cases used it. The specifier was removed and the test cases adjusted accordingly. See: nzbget#52
Across the formats, different specifiers are either buggy or undocumented. To provide a safe way for users to migrate, a deprecation notice has been added. Mapping tuples now can have a third field with a deprecation message that is shown to the user as Warning, when the specifier is replaced. See: nzbget#52
Specifiers %t, %.t, %_t are meant for movie titles and are undocumented for DatedFormat. Newly introduced feature to deprecate specifiers is used to inform user. Closes nzbget#52
Specifiers %tT, %t.T, %t_T (original letter case) were converting case and the test case wrongly checked for case transformation. Naming of variables has been changed, so the ones holding the transformed data start with a "t". Test cases have been adjusted or extended accordingly. Closes nzbget#52
|
Thank you very much! |
|
You're welcome, these are just the changes I had to make to get it working for me ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this became a rather large PR, but I tried to have good documentation in the commit messages.