Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate getting started section of README #17

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Elaborate getting started section of README #17

merged 1 commit into from
Feb 14, 2023

Conversation

ixxie
Copy link
Contributor

@ixxie ixxie commented Feb 7, 2023

Distinguish installation, (minimal) configuration and asset handling steps. Add details for getting the plugin working in SvelteKit.

@ixxie ixxie mentioned this pull request Feb 7, 2023
Copy link
Contributor

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple suggestions, but this looks great – thank you!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ixxie
Copy link
Contributor Author

ixxie commented Feb 8, 2023

@donmccurdy thanks for the suggestions... of course my knowledge is limited here so its nice you filled in the gaps.

I squashed everything together and added you as a coauthor in the commit message.

@juniorxsound juniorxsound requested review from donmccurdy and juniorxsound and removed request for donmccurdy February 9, 2023 20:57
Copy link
Contributor

@juniorxsound juniorxsound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @ixxie! @donmccurdy thoughts?

Copy link
Contributor

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion / looks good to me!

README.md Outdated Show resolved Hide resolved
Distinguish  installation, (minimal) configuration and asset handling
steps. Add details for getting the plugin working in SvelteKit.

Co-authored-by: Don McCurdy <dm@donmccurdy.com>
@juniorxsound juniorxsound merged commit 36815e8 into nytimes:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants