-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Webpack 2.2 #396
Conversation
Running into eslint errors Seems like EDIT: Looks like babel-eslint might be a solution? Or code splitting in starter kyts is blocked until |
FWIW System.import() will still continue to work, it's just deprecated for now. It'll be removed in Webpack 3 I think they said |
Oops, yeah looks like I jumped the gun with replacing System.import(), @tizmagik! Reverting that |
@@ -1,3 +1,4 @@ | |||
{ | |||
"presets": ["kyt-react"] | |||
"presets": ["kyt-react"], | |||
"plugins": ["syntax-dynamic-import"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should just add this plugin to our babel-preset-kyt-core? This seems like something kyt should support/recommend out of the box.
@julianvmodesto - I think we should keep your |
Yea agreed, it would be nice to upgrade to the new |
Sure thing, I'll make these changes –
|
Seems that the Travis build failed since bootstrap.js was expecting yarn 0.19.0 but instead the latest yarn version 0.20.3 was installed.
Not sure how Travis works, but I think we want in the build script:
EDIT: |
@@ -1,15 +1,26 @@ | |||
var babelPresetLatest = require('babel-preset-latest'); | |||
var babelTransformRuntime = require('babel-plugin-transform-runtime'); | |||
var babelTransformModules = require('babel-plugin-transform-es2015-modules-commonjs'); | |||
var babelSyntaxDynamicImport = require('babel-plugin-syntax-dynamic-import'); | |||
var babelEslint = require('babel-eslint'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to add babel-eslint here in packages/babel-preset-kyt-core, but kyt itself is linted with packages/eslint-config-kyt – so I'm guessing I have to add babel-eslint and babel-plugin-syntax-dynamic-import to eslint-config-kyt as well.
Ok, looks like we're good on the Currently troubleshooting an error with the webpackCompiler:
I tried checking out what Tapable is doing, and it's running Googling around for this error and lewie9021/webpack-configurator#2 seems a little insightful – I'm putting some console.log statements in Tapable to see what's happening. Will update as I go along. If anyone has ideas, please let me know! Maybe there's some Webpack 2.2 change that I'm missing. |
404857b
to
c179995
Compare
40ac3e3
to
8c7f62a
Compare
@julianvmodesto - ci test is passing again! I think we should merge #405 before this pull request so that we can run some of the new functional tests against the new webpack and loaders. What do you think is left to do here? |
@julianvmodesto - I got the new functional tests merged in. Looks good 👍 |
Ah great! I don't have anything else to add I think. Merge onwards? |
@jaredmcdonald @ccpricenytimes @tizmagik - Does anyone want to take a look at this? I tested it against our internal app. Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocked by #399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! 👏
What is the status of this? |
Currently blocked by #399, but otherwise all set |
Thank you @julianvmodesto 🙏 |
* master: Upgrade stylelint (#417) Update to Webpack 2.2 (#396) Version and install starter-kyts with npm (#425) adds prep for 0.4.1 (#428) fixes static public path for noServer configuration (#427) Adds local-path argument for testing local starter-kyt setup (#403) # Conflicts: # packages/kyt-core/package.json # packages/kyt-core/yarn.lock # packages/kyt-starter-static/starter-src/yarn.lock # packages/kyt-starter-universal/starter-src/src/yarn.lock # yarn.lock
Issue
#393
work in progress