support user .babelrc #347

jaredmcdonald · 2016-12-13T21:10:15Z

fixes #322

…ment transform in react preset

this is handled as an option in kyt core

… be used with kyt so they should support older versions of node

…ists

…defined

ccpricenytimes

This is really great! Just a couple tiny questions but otherwise looks good. We should document this at the top level and maybe in the starter-kyts to explain how the preset works?

ccpricenytimes · 2016-12-14T01:51:04Z

packages/babel-presets/babel-preset-kyt-react/package.json

+    "babel-preset-kyt-core": "0.1.0-alpha.1",
+    "babel-preset-react": "6.16.0"
+  },
+  "keywords": [


Should we do this for our other packages?

ccpricenytimes · 2016-12-14T02:02:06Z

packages/kyt-core/config/webpack.base.js

+  const hasBabelrc = shell.test('-f', userBabelrcPath);
+  if (!hasBabelrc) {
+    logger.warn('No user .babelrc found. Using kyt default babel preset...');
+  }


Just checking these are the only changes you made in this file yah? The rest of the diff just looks like spacing

yeah, I had to indent everything because it just immediately returned an object before

tizmagik

Couple questions but otherwise LGTM 👍

tizmagik · 2016-12-14T14:32:14Z

packages/babel-presets/babel-preset-kyt-core/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "no-var": 0


I'm also curious of the argument for using < ES2015 in the presets.

maybe this is naive but I figured there's nothing about these presets that really requires them to be used inside kyt, so might as well make them es5 compatible

FWIW these .eslintrc.jsons aren't even honored right now since the root package's lint ignores them (to work around needing to get the eslint config cascade working)

tizmagik · 2016-12-14T14:35:13Z

packages/kyt-cli/cli/actions/setup.js

+  const createBabelrc = () => {
+    // back up existing .babelrc, if it exists
+    if (shell.test('-f', userBabelrcPath)) {
+      const mvTo = path.join(userRootPath, `.babelrc-${date}.bak`);


Maybe append a time stamp so there's no collisions

date is set to Date.now() above so I think we should be ok here?

Oh sorry missed the date bit, yeap perfect 👍

tizmagik · 2016-12-14T14:40:34Z

packages/kyt-core/utils/jest/preprocessor.js

+  if (dep.indexOf('babel') !== 0) {
+    try {
+      resolved = resolve.sync(`${prefix}-${dep}`, { basedir: userRootPath });
+    } catch (e) { /* eslint-disable no-empty */ }


What does this error case mean?

resolve.sync throws if you try to resolve something that doesn't exist. maybe we should log the error?

I think so right? Because this would be an exceptional case, where there's a babel plugin referenced that doesn't exist so it should fail loudly, I think.

@tizmagik added a commit to be noisier about this, f6ad967

jaredmcdonald · 2016-12-14T16:52:15Z

@ccpricenytimes agreed that this needs docs--should I do it here, or in the 0.4.0 docs branch?

…locally

* master: adds the babel presets to the bootstrap (#350) removing temp hack (#348) support user .babelrc (#347) # Conflicts: # .travis.yml

jaredmcdonald and others added 29 commits October 23, 2016 21:21

WIP on babelrc proof of concept

6a09a3c

remove now-unused babel dependencies from main package.json

f0a5d22

better solution for resolving all plugins and presets in user .babelrc

0cd4bfa

parameterize inclusion of babel runtime, and include react inline ele…

3aaf007

…ment transform in react preset

Merge branch 'master' into babelrc

951762a

create .babelrc in starter kyt setup

fe59ec1

Update package.json

99cc9a6

Update package.json

728376a

remove unused RHL dependency

1a20d71

this is handled as an option in kyt core

Merge branch 'master' into babelrc

fde2c16

use var instead of const in packages, these don't necessarily need to…

0b51740

… be used with kyt so they should support older versions of node

alpha.0, keywords, files

8ed645f

add babel-plugin-react-transform-jsx-source, missed in merge earlier

851331f

port over work to resolve babel plugins and presets without prefixes

fb67e16

Merge branch 'master' into babelrc

1f1497c

Merge branch 'master' into babelrc

b1ff996

alpha.1 babel presets

2bcb1f8

use prepublished alpha.1 kyt core babel preset

631ea4f

starter-kyts should use babel-preset-kyt-react

2a0b9cd

add e2e tests that don't pass yet

428543e

Merge branch 'master' into babelrc

81cf6b5

e2e tests pass

1c653e2

webpack should default to babel-preset-kyt-core if no user babelrc ex…

f1b01ed

…ists

jest preprocessor should use kyt-core babel preset if no .babelrc is …

d0c0c18

…defined

es5 the babel-presets further, remove unused .babelrc in kyt-core

001e202

warn if no user .babelrc

877853a

kyt-core doesn't use these plugin/preset dependencies anymore

fbffeac

more mocking in tests to suppress errant log warnings

406c0e1

fix lint

8ef59f8

ccpricenytimes approved these changes Dec 14, 2016

View reviewed changes

tizmagik approved these changes Dec 14, 2016

View reviewed changes

Jared McDonald added 5 commits December 14, 2016 12:20

log erros and exit if a babel plugin or preset is not resolvable

f6ad967

move npm install for root first lint resolve rules pass in e2e tests …

e04c035

…locally

fix tests, unclear why these only started failing on this branch

7b69ecf

add another line to make the frozen-ness tests more clear

18fbc8f

kyt-starter-test is up to date now

9c8ab1d

ccpricenytimes merged commit d803c3e into master Dec 14, 2016

ccpricenytimes deleted the babelrc branch December 14, 2016 21:59

tizmagik added a commit that referenced this pull request Dec 16, 2016

Merge branch 'master' into yarn

9a55776

* master: adds the babel presets to the bootstrap (#350) removing temp hack (#348) support user .babelrc (#347) # Conflicts: # .travis.yml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support user .babelrc #347

support user .babelrc #347

jaredmcdonald commented Dec 13, 2016

ccpricenytimes left a comment

ccpricenytimes Dec 14, 2016

jaredmcdonald Dec 14, 2016

ccpricenytimes Dec 14, 2016

jaredmcdonald Dec 14, 2016

ccpricenytimes Dec 14, 2016

tizmagik left a comment

tizmagik Dec 14, 2016

delambo Dec 14, 2016

jaredmcdonald Dec 14, 2016

jaredmcdonald Dec 14, 2016

tizmagik Dec 14, 2016

jaredmcdonald Dec 14, 2016

tizmagik Dec 14, 2016

tizmagik Dec 14, 2016

jaredmcdonald Dec 14, 2016

tizmagik Dec 14, 2016 •

edited

Loading

jaredmcdonald Dec 14, 2016

jaredmcdonald commented Dec 14, 2016

support user .babelrc #347

support user .babelrc #347

Conversation

jaredmcdonald commented Dec 13, 2016

ccpricenytimes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tizmagik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tizmagik Dec 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredmcdonald commented Dec 14, 2016

tizmagik Dec 14, 2016 •

edited

Loading