adds modifyBabelConfig #235
Conversation
… webpack config assembly; get tests to pass
| if (config.debug) { | ||
| logger.debug('Merged babel configuration:', mergedBabelrc); | ||
| } | ||
| return mergedBabelrc; |
There was a problem hiding this comment.
This is a misnomer right? There's no actual merging going on.
There was a problem hiding this comment.
yeah, maybe modifiedBabelConfig would be more accurate?
There was a problem hiding this comment.
@tizmagik - done
| describe('preprocessor', () => { | ||
| it('calls the babel utility and babel-jest\'s createTransformer', () => { | ||
| const preprocessor = require('../preprocessor'); // eslint-disable-line global-require | ||
| expect(preprocessor).toBe(fakeTransformer); |
There was a problem hiding this comment.
Isn't this just testing Jest's ability to mock?
There was a problem hiding this comment.
ha yeah I suppose, I'll drop this assertion
There was a problem hiding this comment.
although, wait, I added it to verify that preprocessor exports the result of createTransformer
| }); | ||
| expect(babelJest.createTransformer).toBeCalledWith(fakeBabelResult); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Thanks for adding this test!! 🙏
|
Can we pause this? I'd like to see how #250 feels first. |
|
sounds good to me @delambo -- I'll close the PR for now, can always reopen |
fixes #134
adds a
modifyBabelConfigcallback inkyt.config.js