Passes flags to commands

cli/actions/__tests__/dev.test.js

@@ -40,7 +40,8 @@ describe('dev', () => {
     clientURL: mockURL,
     serverURL: mockURL,
     reactHotLoader: false,
-  });
+  },
+  []);
 
   it('cleans the build directory', () => {
     expect(logger.task).toBeCalledWith('Cleaned ./build');
@@ -83,9 +84,9 @@ describe('dev', () => {
   });
 
   it('server compilation done', () => {
+    const flagsStub = [];
     serverCompilerDone(stats);
-
-    expect(nodemon).toBeCalledWith({ script: 'fakePath', watch: ['fakePath'] });
+    expect(nodemon).toBeCalledWith({ script: 'fakePath', watch: ['fakePath'], nodeArgs: flagsStub });
 
     // nodemon.once
     expect(nodemon.once.mock.calls[0][0]).toBe('start');

cli/actions/__tests__/lint.test.js

@@ -7,45 +7,37 @@ jest.setMock('path', {
 jest.mock('../../logger');
 jest.mock('../../../utils/paths');
 
+jest.mock('shelljs', () => (
+  {
+    exec: () => ({
+      stdout: '',
+      code: 0,
+    }),
+  }
+));
+
 describe('lint', () => {
   global.process.exit = jest.fn();
   const logger = require('../../logger');
   const lint = require('../lint');
-  const eslint = require('eslint');
 
   beforeEach(() => {
     jest.resetModules();
   });
 
   it('logs the user linter filename when found', () => {
-    lint();
+    lint({}, []);
     expect(logger.info).toBeCalledWith('Using ESLint file: filename');
   });
 
   it('logs the base filename when there is no user file', () => {
-    lint();
+    lint({}, []);
     expect(logger.info).toBeCalledWith('Using ESLint file: base filename');
   });
 
   it('logs and exits 0 when no errors', () => {
-    lint();
+    lint({}, []);
     expect(logger.end).toBeCalledWith('Your JS looks great ✨');
     expect(process.exit).toBeCalledWith(0);
   });
-
-  it('logs and exits 0 when there are warnings', () => {
-    eslint.__setExecuteOnFiles({ warningCount: 1 }); // eslint-disable-line no-underscore-dangle
-    lint();
-
-    expect(logger.end)
-      .toBeCalledWith('Your JS looks OK, though there were warnings 🤔👆');
-    expect(process.exit).toBeCalledWith(0);
-  });
-
-  it('exits 1 when there are errors', () => {
-    eslint.__setExecuteOnFiles({ errorCount: 1 }); // eslint-disable-line no-underscore-dangle
-    lint();
-
-    expect(process.exit).toBeCalledWith(1);
-  });
 });

cli/actions/__tests__/start.test.js

@@ -7,14 +7,14 @@ const start = require('../start');
 
 describe('start', () => {
   const serverURL = { href: 'href' };
-  start({ serverURL });
+  start({ serverURL }, []);
 
   it('logs start and end', () => {
     expect(logger.start).toBeCalledWith('Starting production...');
     expect(logger.end).toBeCalledWith(`Server running at ${serverURL.href}`);
   });
 
   it('executes the node process asynchronously', () => {
-    expect(shell.exec).toBeCalledWith('node build/server/main.js', { async: true });
+    expect(shell.exec).toBeCalledWith('node build/server/main.js ', { async: true });
   });
 });

cli/actions/dev.js

@@ -15,7 +15,7 @@ const buildConfigs = require('../../utils/buildConfigs');
 const webpackCompiler = require('../../utils/webpackCompiler');
 const { buildPath, serverSrcPath } = require('../../utils/paths')();
 
-module.exports = (config) => {
+module.exports = (config, flags) => {
   logger.start('Starting development build...');
 
   // Kill the server on exit.
@@ -51,7 +51,7 @@ module.exports = (config) => {
       serverCompiler.options.output.path, `${Object.keys(serverCompiler.options.entry)[0]}.js`
     );
 
-    nodemon({ script: serverPath, watch: [serverPath] })
+    nodemon({ script: serverPath, watch: [serverPath], nodeArgs: flags })
       .once('start', () => {
         logger.task(`Server running at: ${serverURL.href}`);
         logger.end('Development started');

cli/actions/lint.js

@@ -1,42 +1,29 @@
 
 // Command to lint src code
 
-const CLIEngine = require('eslint').CLIEngine;
+const shell = require('shelljs');
 const path = require('path');
 const logger = require('./../logger');
 const glob = require('glob');
 const { userRootPath } = require('../../utils/paths')();
 
-module.exports = () => {
+module.exports = (config, flags) => {
   const eslintrc = glob.sync(`${userRootPath}/.*eslintrc*`);
   const configFile = eslintrc.length
       ? eslintrc[0]
       : path.join(__dirname, '../../config/.eslintrc.base.json');
 
   logger.info(`Using ESLint file: ${configFile}`);
 
-  // http://eslint.org/docs/developer-guide/nodejs-api
-  const eslintCLI = {
-    envs: ['browser'],
-    extensions: ['.js'],
-    useEslintrc: true,
-    configFile,
-  };
-
-  // Get the default dir or the dir specified by the user/-d.
   const lint = () => {
-    const files = ['src/'];
-    const cli = new CLIEngine(eslintCLI);
-    const report = cli.executeOnFiles(files);
-    const formatter = cli.getFormatter();
-    logger.log(`${formatter(report.results)}\n`);
-
-    if (report.errorCount === 0) {
-      logger.end(`Your JS looks ${report.warningCount === 0 ? 'great ✨' :
+    const cmd = `eslint src/ -c ${configFile} --color --env browser ${flags.join(' ')}`;
+    const output = shell.exec(cmd);
+    if (output.code === 0) {
+      logger.end(`Your JS looks ${output.stdout === '' ? 'great ✨' :
         'OK, though there were warnings 🤔👆'}`);
     }
 
-    process.exit(report.errorCount > 0 ? 1 : 0);
+    process.exit(output.code > 0 ? 1 : 0);
   };
 
   lint();

cli/actions/setup.js

@@ -18,8 +18,7 @@ const {
 // eslint-disable-next-line import/no-dynamic-require
 const kytPkg = require(path.join(__dirname, '../../package.json'));
 
-module.exports = (config, program) => {
-  const args = program.args[0];
+module.exports = (config, flags, args) => {
   const date = Date.now();
   const tmpDir = path.resolve(userRootPath, '\.kyt-tmp'); // eslint-disable-line no-useless-escape
   const repoURL = args.repository || 'git@github.com:NYTimes/kyt-starter.git';

cli/actions/start.js

@@ -4,8 +4,9 @@
 const shell = require('shelljs');
 const logger = require('./../logger');
 
-module.exports = (config) => {
+module.exports = (config, flags) => {
   logger.start('Starting production...');
-  shell.exec('node build/server/main.js', { async: true });
+  const cmd = `node build/server/main.js ${flags.join(' ')}`;
+  shell.exec(cmd, { async: true });
   logger.end(`Server running at ${config.serverURL.href}`);
 };

cli/actions/test.js

@@ -9,13 +9,10 @@ const { srcPath } = require('../../utils/paths')();
 const buildConfigs = require('../../utils/buildConfigs');
 
 
-module.exports = (config, program) => {
+module.exports = (config, flags) => {
   // Comment the following to see verbose shell ouput.
   shell.config.silent = false;
 
-  // Grab args to pass along (e.g. kyt test -- --watch)
-  const args = program.args.filter(a => typeof a === 'string');
-
   // set BABEL_ENV to test if undefined
   process.env.BABEL_ENV = process.env.BABEL_ENV || 'test';
 
@@ -27,5 +24,5 @@ module.exports = (config, program) => {
   jestConfig = config.modifyJestConfig(clone(jestConfig));
 
   // Run Jest
-  jest.run(['--config', JSON.stringify(jestConfig), ...args]);
+  jest.run(['--config', JSON.stringify(jestConfig), ...flags]);
 };

cli/commands.js

@@ -22,8 +22,10 @@ if (!shell.test('-f', userPackageJSONPath)) {
 }
 
 const loadConfigAndDo = (action, optionalConfig) => {
+  const args = program.args.filter(item => typeof item === 'object');
+  const flags = program.args.filter(item => typeof item === 'string');
   const config = kytConfigFn(optionalConfig);
-  action(config, program);
+  action(config, flags, args);
 };
 
 program
@@ -36,7 +38,8 @@ program
   .option('-C, --config <path>', 'config path')
   .description('Start an express server for development')
   .action(() => {
-    const config = program.args[0].config ? program.args[0].config : null;
+    const args = program.args.filter(item => typeof item === 'object');
+    const config = args[0].config ? args[0].config : null;
     loadConfigAndDo(devAction, config);
   });
 
@@ -45,7 +48,8 @@ program
   .option('-C, --config <path>', 'config path')
   .description('Create a production build')
   .action(() => {
-    const config = program.args[0].config ? program.args[0].config : null;
+    const args = program.args.filter(item => typeof item === 'object');
+    const config = args[0].config ? args[0].config : null;
     loadConfigAndDo(buildAction, config);
   });
 

docs/commands.md

@@ -77,6 +77,13 @@ node_modules/.bin/kyt setup -r git@github.com:delambo/kyt-starter-universal-angu
 The `dev` command takes the entry index.js in `src/client/` and `src/server/`, compiles them, and starts client and backend servers. The dev environment includes hot reloading to allow for fast development.
 Optionally, you can configure urls for the development servers in the [kyt config](/docs/kytConfig.md).
 
+You can pass flags to the node server through `kyt dev`.
+For example:
+```
+kyt dev -- --inspect
+```
+will run the [node debugging for Chrome DevTools](https://medium.com/@paul_irish/debugging-node-js-nightlies-with-chrome-devtools-7c4a1b95ae27#.mpuwgy17v)
+
 ## build
 
 The `build` command takes the entry index.js in `src/client/` and `src/server/`, compiles them, and saves them to a build folder. This is an optimized production build.
@@ -91,6 +98,11 @@ The `start` command takes the compiled code from the production build and runs a
 
 Optionally, you can configure the server url in your [kyt.config.js](/docs/kytConfig.md).
 
+You can also pass flags to node through `kyt start`:
+```
+kyt start -- --no-warnings
+```
+
 ## test
 
 The `test` command takes test files in your `src/` directory and runs them using [Jest](http://facebook.github.io/jest/).