Replace auto_now and auto_now_add with defaults which can be overridden #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Feb 23, 2017
| @@ -15,6 +15,5 @@ celerybeat-schedule | |||
|
|
|||
| *.DS_Store | |||
| .tox/ | |||
| test-runner/env/ | |||
| test-runner/smartmin | |||
rowanseymour
commented
Feb 23, 2017
| csv_imports/ | ||
| !smartmin/csv_imports/ |
There was a problem hiding this comment.
Need this so we exclude /csv_imports but include /smartmin/csv_imports/
rowanseymour
commented
Feb 23, 2017
| @@ -37,15 +36,23 @@ class SmartModel(models.Model): | |||
| created_by = models.ForeignKey(settings.AUTH_USER_MODEL, | |||
| related_name="%(app_label)s_%(class)s_creations", | |||
| help_text="The user which originally created this item") | |||
| created_on = models.DateTimeField(auto_now_add=True, | |||
| created_on = models.DateTimeField(default=timezone.now, editable=False, blank=True, | |||
There was a problem hiding this comment.
blank=True and editable=False were automatically set by auto_now and auto_now_add (see https://docs.djangoproject.com/en/1.10/ref/models/fields/#django.db.models.DateField.auto_now)
rowanseymour
commented
Feb 23, 2017
| @@ -240,12 +247,12 @@ def import_xls(cls, filename, user, import_params, log=None, import_results=None | |||
| num_errors += 1 | |||
|
|
|||
| except SmartImportRowError as e: | |||
| error_messages.append(dict(line=line_number+1, error=text_type(e))) | |||
| error_messages.append(dict(line=line_number+1, error=six.text_type(e))) | |||
There was a problem hiding this comment.
Just making this consistent with how the method is called elsewhere in this file
norkans7
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.