nw-gyp rebuild nodegit error targeting 0.34.x

[hhhoney]

Rebuild nodegit error

(macOS Mojave 10.14.1, node 11.1.0, nwjs 0.34.3, npm 6.4.1, nw-gyp 3.6.3, node-gyp 3.8.0)

--target=0.24.2 is OK
--target=0.34.x Failed

Reproduce:

npm install nodegit

cd node_modules/nodegit

nw-gyp rebuild --target=0.34.3

Error message:

../src/filter_registry.cc:58:21: error: no matching constructor for initialization of 'String::Utf8Value'
  String::Utf8Value name(info[0]->ToString());
                    ^    ~~~~~~~~~~~~~~~~~~~

../src/filter_registry.cc:147:21: error: no matching constructor for initialization of 'String::Utf8Value'
  String::Utf8Value name(info[0]->ToString());
                    ^    ~~~~~~~~~~~~~~~~~~~

[rogerwang]

Does this module work well with Node.js v11.1.0?

[hhhoney]

Yes it does.

[rogerwang]

I think you need to run nw-gyp configure first, or use this simpler way: http://docs.nwjs.io/en/latest/For%20Users/Advanced/Use%20Native%20Node%20Modules/#for-non-lts-releases

[hhhoney]

I have tried the given instructions and the error still exists 😢

some more error messages:

../src/repository.cc:86:21: error: no matching conversion for functional-style cast from 'v8::Local<v8::Value>' to 'String::Utf8Value'
  std::string path(*String::Utf8Value(args[0]));
                    ^~~~~~~~~~~~~~~~~~~~~~~~~

[rogerwang]

Turns out we hit this issue: nodejs/node#23122

Will fix it in NW soon.

[rogerwang]

The reference back to this issue in the upstream one was removed after transferring. So ref it again: nodejs/node#23122

[rogerwang]

The fix is now available with build target '0.34.4' and this build: https://dl.nwjs.io/live-build/nw34/11-15-2018/2d9d6a7ad/v0.34.4/