Implement scroll events on workspace #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just merged from another branch. Could you update your fork to the current |
|
Thanks for looking at this. tell me if you prefer separate PRs for the different things. |
- if numbers is empty, take it from the existing workspaces - add a "hide-empty" configuration to hide empty workspaces
Yes, and well tested, please. Also please discuss major changes before you start working on them. I'm working on further multi-lang support for nwg-shell. Will take a closer look at your PR before the nearest nwg-panel release (and merge if possible). Hopefully this weekend. |
This was referenced Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #178