-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken log file path for NullLsLog #16
Conversation
Is this intended? It's a log file, not a folder |
yes it is. |
Would a more appropriate fix be to ensure that the actual log files are created with the As an aside, it would be really helpful if you could update the PR message to address the problem you are trying to solve. |
The PR is still in draft. |
55065ed
to
866e7a3
Compare
Signed-off-by: Ievgenii Shepeliuk <eshepelyuk@gmail.com>
866e7a3
to
79c0c7d
Compare
The perfect time to discuss proposed changes! 😄 |
🤔 I still didn't get it. What's precisely the bug here? Could you list expected behavior and the actual behavior? |
Oh, I see 🙈. Will check it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing log file is handled by plenary, need further investigation
What sort of investigation ? What are you trying to find, maybe I can answer those question immediately ? |
NullLsLog command is currently broken and does nothing.