Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update vale.sh links #13

Merged
merged 1 commit into from
Nov 13, 2023
Merged

docs: update vale.sh links #13

merged 1 commit into from
Nov 13, 2023

Conversation

Amar1729
Copy link
Collaborator

@Amar1729 Amar1729 commented Nov 8, 2023

Update some outdated links for https://vale.sh/

There may have been some updates to vale since this diagnostic was written. It generally requires you to run vale sync once right after you create your initial .vale.ini, to download styles. Is that ok for none-ls (I'm not too familiar with how this plugin usually works yet), or should the diagnostic be reworked to auto-call vale sync as long as a .vale.ini exists?

@mochaaP
Copy link
Member

mochaaP commented Nov 13, 2023

LGTM.

🤔 As for the vale sync thing, I generally prefer that's something the user should take care of (like installing ESLint presets from NPM).

@mochaaP mochaaP merged commit 65eda7e into nvimtools:main Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants