Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for WFST decoding #161

Merged
merged 26 commits into from
Jun 27, 2023
Merged

Documentation for WFST decoding #161

merged 26 commits into from
Jun 27, 2023

Conversation

anand-nv
Copy link
Contributor

Documentation for Class LM based WFST decoding and Deployment of WFST decoder

anand-nv added 2 commits June 14, 2023 10:29
@anand-nv
Add documentation on wfst decoding in Riva
7df172d 
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
@anand-nv
Update with riva build instructions
3ee38d3 
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
@rmittal-github
Copy link
Collaborator

@anand-nv please move this to release/2.12.0 branch.

@yitagessu @anand-nv
A tutorial on how to create a noisy dataset offline (nvidia-riva#158)
0e224b4 
* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* Changed the noise sample dataset used in the tutorial

* Added comment sections to the tutorial

* Added a top level heading

* corrected a spelling error

* corrected a spelling error

---------

Co-authored-by: ygebremedhin <ygebremedhin@nvidia.com>
@anand-nv anand-nv changed the base branch from main to release/2.12.0 June 22, 2023 05:19
@anand-nv
Copy link
Contributor Author

@anand-nv please move this to release/2.12.0 branch.

Done

@rmittal-github
Copy link
Collaborator

please review @LynseyFabel, this is needed in the release.
@anand-nv there should be a link to these tutorials in the Riva docs on the left pane under Tutorials -> Speech Recognition section, right?

LynseyFabel
LynseyFabel approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@LynseyFabel LynseyFabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left quite a few editorial comments. I've approved assuming they will be implemented. Thank you.

asr-deploy-conformer-wfst.ipynb Outdated Show resolved Hide resolved
asr-deploy-conformer-wfst.ipynb Outdated Show resolved Hide resolved
asr-deploy-conformer-wfst.ipynb Outdated Show resolved Hide resolved
asr-deploy-conformer-wfst.ipynb Outdated Show resolved Hide resolved
asr-deploy-conformer-wfst.ipynb Outdated Show resolved Hide resolved
wfst_class_lm.md Outdated Show resolved Hide resolved
wfst_class_lm.md Outdated Show resolved Hide resolved
wfst_class_lm.md Outdated Show resolved Hide resolved
wfst_class_lm.md Outdated Show resolved Hide resolved
wfst_class_lm.md Outdated Show resolved Hide resolved
LynseyFabel
LynseyFabel approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@LynseyFabel LynseyFabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left quite a few editorial comments. I've approved assuming they will be implemented. Thank you.

anand-nv and others added 16 commits June 27, 2023 20:41
@anand-nv @LynseyFabel
Update wfst_class_lm.md
a098dc8 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update wfst_class_lm.md
b991a41 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update wfst_class_lm.md
5dc5722 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
b21b743 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
4c2e762 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
ba53303 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
d28983f 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update wfst_class_lm.md
fdf0645 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update wfst_class_lm.md
d634dfa 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv
Fix url
3646f0f 
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
@anand-nv
Relative link
8ddc38d 
Fix absolute link
@anand-nv
Change links to relative
6103351
@anand-nv
Add links to WFST tutorials
6c03a5e
@anand-nv
Update README.md
b9bcdf5
@anand-nv
Fix typo in README.md
e4c778d
@anand-nv
Update README.md
8c07783
@anand-nv
Copy link
Contributor Author

please review @LynseyFabel, this is needed in the release. @anand-nv there should be a link to these tutorials in the Riva docs on the left pane under Tutorials -> Speech Recognition section, right?

Yes. Added the links

@anand-nv anand-nv closed this Jun 27, 2023
@anand-nv anand-nv reopened this Jun 27, 2023
anand-nv and others added 6 commits June 28, 2023 00:16
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
fa2bc3f 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Update asr-deploy-conformer-wfst.ipynb
cfd047a 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Apply suggestions from code review
9f36119 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv @LynseyFabel
Code review of asr-noise-augmentation-offline.ipynb
68830a3 
Add review suggestions by @LynselFabel

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv
Update wfst_class_lm.md
c2e32c1
@anand-nv @LynseyFabel
Update asr-noise-augmentation-offline.ipynb
08c9e97 
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
@anand-nv
Copy link
Contributor Author

I've left quite a few editorial comments. I've approved assuming they will be implemented. Thank you.

Thanks. They've been implemented.

@anand-nv anand-nv merged commit 7a2658b into nvidia-riva:release/2.12.0 Jun 27, 2023
rmittal-github added a commit that referenced this pull request Jul 11, 2023
@rmittal-github @anand-nv
@yitagessu @LynseyFabel
Release/2.12.0 (#163)
b915ce0 
* Documentation for WFST decoding (#161)

* Add documentation on wfst decoding in Riva

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Update with riva build instructions

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* A tutorial on how to create a noisy dataset offline (#158)

* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* added a tutorial on noisy data preparation

* Changed the noise sample dataset used in the tutorial

* Added comment sections to the tutorial

* Added a top level heading

* corrected a spelling error

* corrected a spelling error

---------

Co-authored-by: ygebremedhin <ygebremedhin@nvidia.com>

* Update wfst_class_lm.md

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update wfst_class_lm.md

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update wfst_class_lm.md

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update wfst_class_lm.md

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update wfst_class_lm.md

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Fix url

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>

* Relative link

Fix absolute link

* Change links to relative

* Add links to WFST tutorials

* Update README.md

* Fix typo in README.md

* Update README.md

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update asr-deploy-conformer-wfst.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Code review of asr-noise-augmentation-offline.ipynb

Add review suggestions by @LynselFabel

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* Update wfst_class_lm.md

* Update asr-noise-augmentation-offline.ipynb

Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

---------

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Co-authored-by: yitagessu <61555053+yitagessu@users.noreply.github.com>
Co-authored-by: ygebremedhin <ygebremedhin@nvidia.com>
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>

* WFST based customization: ARPA doesn't require vocab list (#162)

WFST based customization: ARPA doesn't require vocab list

---------

Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
Co-authored-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Co-authored-by: yitagessu <61555053+yitagessu@users.noreply.github.com>
Co-authored-by: ygebremedhin <ygebremedhin@nvidia.com>
Co-authored-by: LynseyFabel <46456803+LynseyFabel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LynseyFabel LynseyFabel LynseyFabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anand-nv @rmittal-github @LynseyFabel @yitagessu