Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links and capitalization of "Docker" in ASR deployment tutorials #159

Merged
merged 8 commits into from
Jun 9, 2023

Conversation

svenchilton
Copy link
Collaborator

I had accidentally merged my previous pull requests before implementing these changes which @LynseyFabel suggested

…rce folder does, indeed, include a .whl file for the nemo2riva tool now.

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
…rce folder does, indeed, include a .whl file for the nemo2riva tool now.

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
… in the Python version in which I was running it. Why that should affect the notebook file that I push to GitHub is beyond me.

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
…ed the config.sh snippet and its Markdown formatting; (2) added a cell which allows users to edit config.sh without opening it; (3) deleted my function for getting an audio file's encoding and calls to it; (4) deleted the call to riva.client.add_audio_file_specs_to_config(); (5) updated the instructional comment on what types of audio file to pass into the ASR inference function; (6) changed the command at the end of the notebook for stopping the Riva server.

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
…cell between the config.sh code snippet and the cell allowing the user to edit config.sh without opening it

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
…e Riva Skills Quick Start config.sh script in the ASR deployment tutorials

Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
Signed-off-by: Sven Chilton <sven.chilton@gmail.com>
@svenchilton svenchilton requested a review from LynseyFabel June 8, 2023 16:29
Copy link
Contributor

@LynseyFabel LynseyFabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svenchilton svenchilton merged commit 96a6139 into main Jun 9, 2023
@svenchilton svenchilton deleted the sven-fix-asr-deployment-notebooks branch June 9, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants