Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hindi ASR tutorial markdown #15

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Hindi ASR tutorial markdown #15

merged 2 commits into from
Apr 21, 2022

Conversation

AshishSardana
Copy link
Contributor

Replacement of #11 - converted notebook to markdown.

@AshishSardana AshishSardana mentioned this pull request Apr 19, 2022
Closed
@NikhilSrihari
Copy link
Contributor

NikhilSrihari commented Apr 19, 2022 •
edited
Loading

@AshishSardana

  1. Pls remove license info - It should be in the main Readme.md file only
  2. Can we add all images to a subfolder?
  3. Riva deploymnent section - Pls add more info and links here. Example: https://github.com/nvidia-riva/tutorials/tree/dev/22.04/New-language-adaptation/German#4-riva-deployment

@AshishSardana
Copy link
Contributor Author

@NikhilSrihari Done!

@NikhilSrihari NikhilSrihari merged commit 8ba6e7c into dev/22.04 Apr 21, 2022
NikhilSrihari added a commit that referenced this pull request Apr 22, 2022
@NikhilSrihari @AshishSardana
@nikhilsrihari18 @cparisien
22.04 QA RC1 - Update 2 (#20)
6e2e955 
* Hindi ASR tutorial markdown (#15)

* nb to md

* fixes based on nikhil's review

* JARS-2037 and JARS-2038 (#18)

* JARS-2037 and JARS-2038

* Delete ipynb checkpoint

* Review updates

Co-authored-by: nsrihari <nsrihari@nvidia.com>

* EKS deployment doc (#17)

* EKS deployment doc

* Revisions for style consistency and review feedback

Co-authored-by: Ashish Sardana <ashishsardana21@gmail.com>
Co-authored-by: nsrihari <nsrihari@nvidia.com>
Co-authored-by: Chris Parisien <64271260+cparisien@users.noreply.github.com>
@AshishSardana AshishSardana deleted the asardana/hindi-tutorial-md branch August 3, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikhilSrihari NikhilSrihari Awaiting requested review from NikhilSrihari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshishSardana @NikhilSrihari