Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adopt more precise naming for data access layer components. #435

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: Adopt more precise naming for data access layer components. #435

merged 1 commit into from
Feb 25, 2025

Conversation

jeanplevesque
Copy link
Member

@jeanplevesque jeanplevesque commented Feb 25, 2025 •
edited
Loading

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

  • Removed unnecessary IsExternalInit.cs files.
  • Renamed multiple components from the data access layer to not all be named Repository.
    • Adjusted architecture documentation accordingly.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@jeanplevesque jeanplevesque merged commit 245dcbb into main Feb 25, 2025
14 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/various-fixes branch February 25, 2025 17:49
carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Access/ApiClients/KillSwitch/KillSwitchDataSourceMock.cs
@@ -7,7 +7,7 @@ namespace ApplicationTemplate.DataAccess;
/// <summary>
/// Mock implementation of the kill switch repository.
Copy link
Contributor

@carlh98 carlh98 Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Access/ApiClients/MinimumVersion/MinimumVersionProviderMock.cs
@@ -6,7 +6,7 @@ namespace ApplicationTemplate.DataAccess;
/// <summary>
/// A mock implementation of the minimum version repository. Used for testing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Access/Configuration/NativePlatformConfiguration.cs
@@ -16,7 +16,7 @@ public static class NativePlatformConfiguration
public static IServiceCollection AddNativePlaformRepositories(this IServiceCollection services)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Business/ForcedUpdates/UpdateRequiredService.cs
@@ -14,10 +14,10 @@ public sealed class UpdateRequiredService : IUpdateRequiredService, IDisposable
/// <summary>
/// Initializes a new instance of the <see cref="UpdateRequiredService"/> class.
/// </summary>
/// <param name="minimumVersionReposiory">A repository that contains an observable we can use to update the app.</param>
public UpdateRequiredService(IMinimumVersionReposiory minimumVersionReposiory)
/// <param name="minimumVersionProvider">A repository that contains an observable we can use to update the app.</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Shared.Views/Framework/DiagnosticsService.cs
@@ -27,7 +27,7 @@ public sealed class DiagnosticsService : IDiagnosticsService
private readonly IDispatcherScheduler _dispatcherScheduler;
private readonly IOptions<ReadOnlyConfigurationOptions> _configurationOptions;
private readonly ILogger _logger;
private readonly IEmailRepository _emailRepository;
private readonly IEmailService _emailRepository;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
src/app/ApplicationTemplate.Shared.Views/Framework/DiagnosticsService.cs
@@ -40,7 +40,7 @@ public DiagnosticsService(
IDispatcherScheduler dispatcherScheduler,
IOptions<ReadOnlyConfigurationOptions> configurationOptions,
ILogger<DiagnosticsService> logger,
IEmailRepository emailRepository,
IEmailService emailRepository,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

carlh98
carlh98 reviewed Feb 25, 2025
View reviewed changes
...cationTemplate.Presentation/ViewModels/Diagnostics/Navigation/NavigationDebuggerViewModel.cs
});

/// <summary>
/// Gets a command that raises the kill switch event.
/// </summary>
public IDynamicCommand TriggerKillSwitch => this.GetCommand(() =>
{
var killSwitchRepository = this.GetService<IKillSwitchRepository>();
var killSwitchRepository = this.GetService<IKillSwitchDataSource>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlh98 carlh98 carlh98 left review comments

@Soap-141 Soap-141 Soap-141 approved these changes

@Lee31416 Lee31416 Lee31416 approved these changes

@Marc-Antoine-Soucy Marc-Antoine-Soucy Marc-Antoine-Soucy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeanplevesque @carlh98 @Soap-141 @Lee31416 @Marc-Antoine-Soucy