Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing material resource key MaterialCommandBarHeight #429

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Lee31416
Copy link
Contributor

@Lee31416 Lee31416 commented Feb 1, 2025

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

The commandbar height property was not needed and causing problems on windows. Plus on other projects we either don't set it or we set it to 48 manually which is the value in uno.material. I found that even without the setter the commandbar has the same height by default.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Lee31416 Lee31416 self-assigned this Feb 1, 2025
@Lee31416 Lee31416 force-pushed the dev/topi/fix-material-bug branch from 728d762 to d497d8a Compare February 1, 2025 17:58
@Lee31416 Lee31416 changed the base branch from main to feature/uno-update February 1, 2025 17:59
@Lee31416 Lee31416 marked this pull request as ready for review February 1, 2025 17:59
@Lee31416 Lee31416 merged commit 621749c into feature/uno-update Feb 3, 2025
15 checks passed
@Lee31416 Lee31416 deleted the dev/topi/fix-material-bug branch February 3, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants