Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs in web pages in Firefox and Chrome now get browseMode if the parent document also has browseMode #7433

Merged
merged 6 commits into from
Aug 29, 2017
Prev Previous commit
Next Next commit
MSHTML VBufBackend: Although applications and dialogs should render t…
…heir label when embedded in a document, we should not do this when the dialog or application is the root of the buffer as we lose all the content if this particular application or dialog gets browse mode itself.
  • Loading branch information
michaelDCurran committed Aug 1, 2017
commit eff34ca44bc30afc32325dc490d4d9dc10a251b2
2 changes: 1 addition & 1 deletion nvdaHelper/vbufBackends/mshtml/mshtml.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ if(!(formatState&FORMATSTATE_INSERTED)&&nodeName.compare(L"INS")==0) {
// Whether the name is the content of this node.
bool nameIsContent = (IARole == ROLE_SYSTEM_LINK || IARole == ROLE_SYSTEM_PUSHBUTTON || IARole == ROLE_SYSTEM_MENUITEM || IARole == ROLE_SYSTEM_GRAPHIC || IARole == ROLE_SYSTEM_PAGETAB
|| ariaRole == L"heading" || (nodeName[0] == L'H' && iswdigit(nodeName[1]))
|| nodeName == L"OBJECT" || nodeName == L"APPLET" || IARole == ROLE_SYSTEM_APPLICATION || IARole == ROLE_SYSTEM_DIALOG);
|| nodeName == L"OBJECT" || nodeName == L"APPLET" || (!isRoot && (IARole == ROLE_SYSTEM_APPLICATION || IARole == ROLE_SYSTEM_DIALOG)));
// True if the name definitely came from the author.
bool nameFromAuthor=false;

Expand Down