Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update updateCheck and addonStore URLs to use new NV Access endpoints #17680

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Update updateCheck and addonStore URLs to use new NV Access endpoints #17680

merged 1 commit into from
Feb 7, 2025

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Feb 7, 2025 •
edited
Loading

Link to issue number:

None

Summary of the issue:

NV Access has changed the update check and add-on store endpoint URLS.
While these are forwarded for now, NVDA should migrate over

Description of user facing changes

Use new URLs

Description of development approach

Use new URLs

Testing strategy:

Tested by setting mirrors manually in NVDA settings

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd requested a review from a team as a code owner February 7, 2025 04:25
@seanbudd seanbudd requested a review from SaschaCowley February 7, 2025 04:25
SaschaCowley
SaschaCowley approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @seanbudd

@SaschaCowley SaschaCowley merged commit ffd1cf5 into master Feb 7, 2025
5 checks passed
@SaschaCowley SaschaCowley deleted the updateURLs branch February 7, 2025 06:15
@github-actions github-actions bot added this to the 2025.1 milestone Feb 7, 2025
@CyrilleB79
Copy link
Collaborator

Are we sure that URL forwarding works?

This morning, I get the following error after having started NVDA 2024.4.2:

ERROR - addonStore.dataManager._DataManager._getCacheHash (07:51:15.606) - initialiseAvailableAddons (14180):
Unable to get data from API (https://nvaccess.org/addonStore/cacheHash.json), response (500): b'<!DOCTYPE html>\n<html dir=\'ltr\'>\n<head>\n\t<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />\n\t<meta name="viewport" content="width=device-width, initial-scale=1.0">\n\t\t\t<title>Database Error</title>\n\t<style type="text/css">\n\t\thtml {\n\t\t\tbackground: #f1f1f1;\n\t\t}\n\t\tbody {\n\t\t\tbackground: #fff;\n\t\t\tborder: 1px solid #ccd0d4;\n\t\t\tcolor: #444;\n\t\t\tfont-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;\n\t\t\tmargin: 2em auto;\n\t\t\tpadding: 1em 2em;\n\t\t\tmax-width: 700px;\n\t\t\t-webkit-box-shadow: 0 1px 1px rgba(0, 0, 0, .04);\n\t\t\tbox-shadow: 0 1px 1px rgba(0, 0, 0, .04);\n\t\t}\n\t\th1 {\n\t\t\tborder-bottom: 1px solid #dadada;\n\t\t\tclear: both;\n\t\t\tcolor: #666;\n\t\t\tfont-size: 24px;\n\t\t\tmargin: 30px 0 0 0;\n\t\t\tpadding: 0;\n\t\t\tpadding-bottom: 7px;\n\t\t}\n\t\t#error-page {\n\t\t\tmargin-top: 50px;\n\t\t}\n\t\t#error-page p,\n\t\t#error-page .wp-die-message {\n\t\t\tfont-size: 14px;\n\t\t\tline-height: 1.5;\n\t\t\tmargin: 25px 0 20px;\n\t\t}\n\t\t#error-page code {\n\t\t\tfont-family: Consolas, Monaco, monospace;\n\t\t}\n\t\tul li {\n\t\t\tmargin-bottom: 10px;\n\t\t\tfont-size: 14px ;\n\t\t}\n\t\ta {\n\t\t\tcolor: #2271b1;\n\t\t}\n\t\ta:hover,\n\t\ta:active {\n\t\t\tcolor: #135e96;\n\t\t}\n\t\ta:focus {\n\t\t\tcolor: #043959;\n\t\t\tbox-shadow: 0 0 0 2px #2271b1;\n\t\t\toutline: 2px solid transparent;\n\t\t}\n\t\t.button {\n\t\t\tbackground: #f3f5f6;\n\t\t\tborder: 1px solid #016087;\n\t\t\tcolor: #016087;\n\t\t\tdisplay: inline-block;\n\t\t\ttext-decoration: none;\n\t\t\tfont-size: 13px;\n\t\t\tline-height: 2;\n\t\t\theight: 28px;\n\t\t\tmargin: 0;\n\t\t\tpadding: 0 10px 1px;\n\t\t\tcursor: pointer;\n\t\t\t-webkit-border-radius: 3px;\n\t\t\t-webkit-appearance: none;\n\t\t\tborder-radius: 3px;\n\t\t\twhite-space: nowrap;\n\t\t\t-webkit-box-sizing: border-box;\n\t\t\t-moz-box-sizing:    border-box;\n\t\t\tbox-sizing:         border-box;\n\n\t\t\tvertical-align: top;\n\t\t}\n\n\t\t.button.button-large {\n\t\t\tline-height: 2.30769231;\n\t\t\tmin-height: 32px;\n\t\t\tpadding: 0 12px;\n\t\t}\n\n\t\t.button:hover,\n\t\t.button:focus {\n\t\t\tbackground: #f1f1f1;\n\t\t}\n\n\t\t.button:focus {\n\t\t\tbackground: #f3f5f6;\n\t\t\tborder-color: #007cba;\n\t\t\t-webkit-box-shadow: 0 0 0 1px #007cba;\n\t\t\tbox-shadow: 0 0 0 1px #007cba;\n\t\t\tcolor: #016087;\n\t\t\toutline: 2px solid transparent;\n\t\t\toutline-offset: 0;\n\t\t}\n\n\t\t.button:active {\n\t\t\tbackground: #f3f5f6;\n\t\t\tborder-color: #7e8993;\n\t\t\t-webkit-box-shadow: none;\n\t\t\tbox-shadow: none;\n\t\t}\n\n\t\t\t</style>\n</head>\n<body id="error-page">\n\t<div class="wp-die-message"><h1>Error establishing a database connection</h1></div></body>\n</html>\n\t'

@seanbudd
Copy link
Member Author

seanbudd commented Feb 7, 2025

@CyrilleB79 - we're experiencing some server problems right now, both the old URL (which just forwards) and new URL is down

cary-rowen added a commit to nvdacn/NVDAUpdateMirror that referenced this pull request Feb 7, 2025
@cary-rowen
Update updateCheck and addonStore URLs to use new NV Access mirror en…
4932026 
…dpoints, See nvaccess/nvda#17680
This was referenced Feb 9, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@seanbudd @CyrilleB79 @SaschaCowley