Skip to content

Commit

Permalink
only exit if silent install or portable copy starting (#12455)
Browse files Browse the repository at this point in the history
#12431 introduced a change where NVDA always exits at the end of creating a portable copy. The intention was to change the behaviour 

from
exit NVDA if it is a silent install
to
exit NVDA if it is a silent install, or if we are starting the portable copy.

As a result of #12431, finishing the install of a portable copy without starting it also results in NVDA exiting.
  • Loading branch information
seanbudd authored May 24, 2021
1 parent a3b6c23 commit 2ad4ce2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/gui/installerGui.py
Original file line number Diff line number Diff line change
Expand Up @@ -482,4 +482,5 @@ def doCreatePortable(portableDirectory,copyUserConfig=False,silent=False,startAf
def startNewPortableNVDAInstance():
_startNewNVDAInstance(portableDirectory)
core.preNVDAExit.register(startNewPortableNVDAInstance)
core.triggerNVDAExit()
if silent or startAfterCreate:
core.triggerNVDAExit()

0 comments on commit 2ad4ce2

Please sign in to comment.