-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflow #3634
Fix workflow #3634
Conversation
Summary of the issueIn #3294 @josephsl has detected the exact bug. Testhttps://github.com/nvdaes/addon-datastore/actions/runs/9237486054 Note: I've exceeded my VirusTotal API key limit today, trying to analyze all add-ons of the store, but the workflow syntax should be fixed. |
I'll submit this to the add-ons mailing list, in case people prefer to wait until this PR is merged. |
Hi, Thanks for resolving it. |
Thanks @josephsl for your review. |
I've submitted clipContentsDesigner 34.0.0 add-on and VirusTotal is not generating a complete json file. Previously this has worked well. This is the same error that I'm finding when I try to analyze all add-ons. |
I've seen a recent workflow,and in the VirusTotal job the API key value is blank. NV Access may investigate if the name provided in the workflow for the NV Access secret is right, since in my fork API key is assigned to ***work. |
@nvdaes - can you add logging to catch this error and log the content returned by VT? SyntaxError: Unexpected end of JSON input
at JSON.parse (<anonymous>)
at D:\a\addon-datastore\addon-datastore\.github\workflows\virusTotalAnalysis.js:[19](https://github.com/nvaccess/addon-datastore/actions/runs/9241840563/job/25423917854#step:5:20):25
at ChildProcess.exithandler (node:child_process:430:5)
at ChildProcess.emit (node:events:514:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5) |
Thanks @seanbudd , I'mdoing it, and I expect to create a PR in addon-datastore-staging repo with logging. |
Seems that files aren't found, since in one of my tests I submitted a sendJsonFile without steps to scan the add-on when the issue is created, to be analyzed later. |
No description provided.