-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFP MultiFileSource optionally poll for file updates #978
Merged
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-polling-multifile-source-975
Jun 21, 2023
Merged
DFP MultiFileSource optionally poll for file updates #978
rapids-bot
merged 12 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-polling-multifile-source-975
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
requested changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one fix to counting incremental time and we should be good.
examples/digital_fingerprinting/production/morpheus/dfp/stages/multi_file_source.py
Outdated
Show resolved
Hide resolved
… should be vased on the time at the start of the loop, this includes work we did in addition to yielding to the output channel
mdemoret-nv
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question.
examples/digital_fingerprinting/production/morpheus/dfp/stages/multi_file_source.py
Show resolved
Hide resolved
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MultiFileSource
:watch
andwatch_interval
, whenwatch
is True the source will poll the input file globs everywatch_interval
seconds for new files.--watch_inputs
and--watch_interval
on the command lineI spent some time looking into what the impacts of this change would be on the rest of the pipeline:
DFPFileBatcherStage
: Assuming that the watch_interval is smaller than theperiod
argument toDFPFileBatcherStage
, and assuming that new files are actually new (not historical files recently fetched) then this will cause all most new files to likely be batched together, unless they straddle the period boundary. This should be OK and is likely the desired outcome.DFPRollingWindowStage
: This should be OK, the stage appends incoming data to the existing history for the user. However, there is a potential issue if new files are older than existing files already ingested. This could potentially happen if the files appearing in the directory could be populated from an outside source not in creation order.fixes #975
Checklist