Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Remove md and rst from copyright check #759

Closed

Conversation

jarmak-nv
Copy link
Contributor

Minor change to the copyright CI check - text documents (.md and .rst) presented as-is to users don't need a copyright header.

@jarmak-nv jarmak-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Mar 13, 2023
@jarmak-nv jarmak-nv requested a review from a team as a code owner March 13, 2023 20:46
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforcing copyright headers on md & rst files was explicitly added in #635 the reasoning being that we had a significant amount of content in our documentation.

@jarmak-nv
Copy link
Contributor Author

Fair enough! I'll update this to exclude specifically the PULL_REQUEST_TEMPLATE.md file

@dagardner-nv
Copy link
Contributor

Fair enough! I'll update this to exclude specifically the PULL_REQUEST_TEMPLATE.md file

You could also just ignore anything in the .github dir, or just toss the license header in there if we wrote it.

@jarmak-nv
Copy link
Contributor Author

You could also just ignore anything in the .github dir, or just toss the license header in there if we wrote it.

Yeah I thought about the .github dir but I think some of the actions we write/use might need it in the future so leaving it in. I would just toss the license in but I don't know for sure if we're the original authors and people would need to delete it each time they opened a PR.

Also after talking with @mdemoret-nv I can just update copyright.py in the PR that adds the new file, so closing this.

@jarmak-nv jarmak-nv closed this Mar 14, 2023
@jarmak-nv jarmak-nv deleted the update-copyright-ci branch August 31, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants