Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in README.md & Change GitLab-style reference in CONTRIBUTING.md #74

Merged
merged 2 commits into from
May 2, 2022
Merged

Fix typos in README.md & Change GitLab-style reference in CONTRIBUTING.md #74

merged 2 commits into from
May 2, 2022

Conversation

lobotmcj
Copy link
Contributor

@lobotmcj lobotmcj commented Apr 29, 2022 •
edited
Loading

Closes #73

@lobotmcj
docs: small fixes in README.md and CONTRIBUTING.md
e217d92 
fixes typos in README.md
removes one remaining gitlab merge-request term in CONTRIBUTING.md
@lobotmcj
Copy link
Contributor Author

Really excited that you guys got this to GA. Congrats!
I'd add labels to fix the Label Checker but it looks like I don't have permissions, which makes sense.

@lobotmcj lobotmcj mentioned this pull request Apr 29, 2022
Closed
cwharris
cwharris approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@cwharris cwharris added non-breaking Non-breaking change doc Improvements or additions to documentation labels Apr 29, 2022
pdmack
pdmack approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@pdmack pdmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lobotmcj . Excited to have you contributing to the project!
LGTM

@BartleyR BartleyR merged commit d61f9ab into nv-morpheus:branch-22.06 May 2, 2022
@dagardner-nv dagardner-nv mentioned this pull request Jul 15, 2024
Merged
dagardner-nv added a commit to dagardner-nv/Morpheus that referenced this pull request Jul 16, 2024
@dagardner-nv
Adopt nv-morpheus/utilities/nv-morpheus#74
ca0e011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@pdmack pdmack pdmack approved these changes

@BartleyR BartleyR BartleyR approved these changes

@mdemoret-nv mdemoret-nv Awaiting requested review from mdemoret-nv

@raykallen raykallen Awaiting requested review from raykallen

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Typos in README.md; one more GitLab-style term in CONTRIBUTING.md
4 participants
@lobotmcj @cwharris @pdmack @BartleyR