Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quickstart Guide #398

Merged
3 commits merged into from
Oct 21, 2022
Merged

Update Quickstart Guide #398

3 commits merged into from
Oct 21, 2022

Conversation

bsuryadevara
Copy link
Contributor

  • To make the command easier to copy and paste, the $ symbol was removed.
  • Removed duplicate table of contents

@bsuryadevara bsuryadevara added doc Improvements or additions to documentation 2 - In Progress labels Oct 11, 2022
@bsuryadevara bsuryadevara self-assigned this Oct 11, 2022
@bsuryadevara bsuryadevara requested a review from a team as a code owner October 11, 2022 16:06
@bsuryadevara bsuryadevara marked this pull request as draft October 11, 2022 16:06
@bsuryadevara bsuryadevara changed the title Update Quickstart Guide [DRAFT] Update Quickstart Guide Oct 11, 2022
@bsuryadevara bsuryadevara requested a review from pdmack October 11, 2022 16:06
@bsuryadevara bsuryadevara linked an issue Oct 11, 2022 that may be closed by this pull request
[DOC]-$ sign is copied when using the copy icon. #338
Closed
@bsuryadevara bsuryadevara changed the base branch from branch-22.09 to branch-22.11 October 11, 2022 16:17
@bsuryadevara bsuryadevara added the non-breaking Non-breaking change label Oct 11, 2022
@bsuryadevara
Copy link
Contributor Author

/ok to test

@bsuryadevara
Copy link
Contributor Author

/rerun tests

@bsuryadevara bsuryadevara changed the title [DRAFT] Update Quickstart Guide Update Quickstart Guide Oct 11, 2022
@bsuryadevara bsuryadevara marked this pull request as ready for review October 11, 2022 16:27
mdemoret-nv
mdemoret-nv requested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look over the entire repo and make sure this is consistent everywhere? The rule should be:

  • If there is no output from the command shown, any leading $ or # should be removed so the command can be copied
  • If the command is followed by output, a leading $ should be added to differentiate the command from the output

@bsuryadevara bsuryadevara requested review from a team as code owners October 18, 2022 15:06
@bsuryadevara
Copy link
Contributor Author

Can you look over the entire repo and make sure this is consistent everywhere? The rule should be:

  • If there is no output from the command shown, any leading $ or # should be removed so the command can be copied
  • If the command is followed by output, a leading $ should be added to differentiate the command from the output

@mdemoret-nv removed leading $ at all the places as per the instruction.

@BartleyR
Copy link
Contributor

@bsuryadevara @mdemoret-nv Are we good to merge this then?

@bsuryadevara
Copy link
Contributor Author

@bsuryadevara @mdemoret-nv Are we good to merge this then?

There are no other locations with leading $, so merging should be okay.

@mdemoret-nv
Copy link
Contributor

rerun tests

mdemoret-nv
mdemoret-nv approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI passes

@dagardner-nv
Copy link
Contributor

/rerun tests

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit b303f7a into nv-morpheus:branch-22.11 Oct 21, 2022
@bsuryadevara bsuryadevara deleted the update-quickstart-guide branch February 6, 2023 15:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@pdmack pdmack Awaiting requested review from pdmack

Assignees

@bsuryadevara bsuryadevara

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]-$ sign is copied when using the copy icon.
4 participants
@bsuryadevara @BartleyR @mdemoret-nv @dagardner-nv