Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pandas version in runtime container #270

Merged
33 commits merged into from
Jul 15, 2022
Merged

Fix pandas version in runtime container #270

33 commits merged into from
Jul 15, 2022

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jul 12, 2022 •
edited
Loading

  • Add pandas 1.3 to conda recipe. This will allow pandas version in conda package to match pandas from runtime pip dependencies. When they don't match pypi package was being installed.
  • Update Dockerfile so that runtime container build conda installs morpheus before installing runtime pip dependencies. pandas from conda-forge will first be installed. Since pandas from requirements.txt will also resolve to 1.3, pandas from conda-forge will now be kept.
  • Update log parsing example to explicitly convert cupy arrays to numpy in postprocessing stage. Implicit conversion causes error in pandas 1.4.3. See [BUG] log parsing example failure  #267.

Fixes #267

dependabot bot and others added 30 commits June 22, 2022 05:08
@dependabot
Bump numpy in /models/validation-inference-scripts/phishing-models
47b8cbf 
Bumps [numpy](https://github.com/numpy/numpy) from 1.20.3 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/HOWTO_RELEASE.rst)
- [Commits](numpy/numpy@v1.20.3...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@raykallen
Merge pull request nv-morpheus#173 from nv-morpheus/dependabot/pip/mo…
1dd7e4f 
…dels/validation-inference-scripts/phishing-models/numpy-1.22.0

Bump numpy from 1.20.3 to 1.22.0 in /models/validation-inference-scripts/phishing-models
@dependabot
Bump numpy
8021159 
Bumps [numpy](https://github.com/numpy/numpy) from 1.19.5 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/HOWTO_RELEASE.rst)
- [Commits](numpy/numpy@v1.19.5...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@raykallen
Merge pull request nv-morpheus#175 from nv-morpheus/dependabot/pip/mo…
dd36e4b 
…dels/validation-inference-scripts/fraud-detection-models/numpy-1.22.0

Bump numpy from 1.19.5 to 1.22.0 in /models/validation-inference-scripts/fraud-detection-models
@dependabot
Bump numpy in /models/training-tuning-scripts/fraud-detection-models
21dd0fa 
Bumps [numpy](https://github.com/numpy/numpy) from 1.19.5 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/HOWTO_RELEASE.rst)
- [Commits](numpy/numpy@v1.19.5...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@raykallen
Merge pull request nv-morpheus#174 from nv-morpheus/dependabot/pip/mo…
b0a033c 
…dels/training-tuning-scripts/fraud-detection-models/numpy-1.22.0

Bump numpy from 1.19.5 to 1.22.0 in /models/training-tuning-scripts/fraud-detection-models
@dependabot
Bump numpy in /models/validation-inference-scripts/hammah-models
46048a6 
Bumps [numpy](https://github.com/numpy/numpy) from 1.20.3 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/HOWTO_RELEASE.rst)
- [Commits](numpy/numpy@v1.20.3...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@raykallen
Merge pull request nv-morpheus#172 from nv-morpheus/dependabot/pip/mo…
45b31f8 
…dels/validation-inference-scripts/hammah-models/numpy-1.22.0

Bump numpy from 1.20.3 to 1.22.0 in /models/validation-inference-scripts/hammah-models
@mdemoret-nv
Merge pull request nv-morpheus#184 from nv-morpheus/branch-22.06
36480ae 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@mdemoret-nv
Merge pull request nv-morpheus#187 from nv-morpheus/branch-22.06
e51f74b 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#194 from nv-morpheus/branch-22.06
526cb75 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#202 from nv-morpheus/branch-22.06
2fa2182 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#204 from nv-morpheus/branch-22.06
57635e7 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#222 from nv-morpheus/branch-22.06
0f5d678 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#225 from nv-morpheus/branch-22.06
a234210 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#226 from nv-morpheus/branch-22.06
771cce7 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#227 from nv-morpheus/branch-22.06
2842793 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#228 from nv-morpheus/branch-22.06
0a63565 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#233 from nv-morpheus/branch-22.06
0f186a7 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#235 from nv-morpheus/branch-22.06
f9beca9 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#236 from nv-morpheus/branch-22.06
6f81ba1 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#241 from nv-morpheus/branch-22.06
1f25ba9 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#247 from nv-morpheus/branch-22.06
2018d06 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#248 from nv-morpheus/branch-22.06
dfb4a10 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#253 from nv-morpheus/branch-22.06
c168047 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#255 from nv-morpheus/branch-22.06
1d18cd4 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#260 from nv-morpheus/branch-22.06
8edb3ae 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@dagardner-nv
GPU not needed for build & documentation CI stages (nv-morpheus#181)
10ea14f 
Also:
- Simplifies build script.
- Build stage now has access to 16 cores (prev 10)
- Log output of `lscpu` so we have a better idea what sort of host we are running on.

Fixes nv-morpheus#115

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: nv-morpheus#181
@GPUtester
Merge pull request nv-morpheus#263 from nv-morpheus/branch-22.06
1a0fd7d 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@GPUtester
Merge pull request nv-morpheus#264 from nv-morpheus/branch-22.06
64564e1 
[gpuCI] Forward-merge branch-22.06 to branch-22.08 [skip gpuci]
@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels Jul 12, 2022
@efajardo-nv efajardo-nv requested a review from a team as a code owner July 12, 2022 18:28
@efajardo-nv
Copy link
Contributor Author

Investigating why wrong pandas version (1.4.3) is being pip installed in container.

dagardner-nv
dagardner-nv approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efajardo-nv efajardo-nv changed the title Log parsing postproc fix Fix pandas version in runtime container Jul 14, 2022
@BartleyR
Copy link
Contributor

@mdemoret-nv Do you have a problem with back porting this to 22.06?

mdemoret-nv
mdemoret-nv approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv mdemoret-nv changed the base branch from branch-22.08 to branch-22.06 July 14, 2022 21:34
@mdemoret-nv
Copy link
Contributor

retargeting to 22.06 for a hotfix

@mdemoret-nv
Copy link
Contributor

rerun tests

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 1f700a3 into nv-morpheus:branch-22.06 Jul 15, 2022
@pdmack pdmack mentioned this pull request Jul 18, 2022
Closed
@efajardo-nv efajardo-nv deleted the log-parsing-fix branch July 29, 2024 21:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] log parsing example failure
6 participants
@efajardo-nv @BartleyR @mdemoret-nv @dagardner-nv @raykallen @GPUtester