-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Morpheus Data Files Out of LFS #242
Merged
mdemoret-nv
merged 12 commits into
nv-morpheus:branch-22.06
from
mdemoret-nv:mdd_debug-conda-build
Jun 30, 2022
Merged
Move Morpheus Data Files Out of LFS #242
mdemoret-nv
merged 12 commits into
nv-morpheus:branch-22.06
from
mdemoret-nv:mdd_debug-conda-build
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2022
dagardner-nv
requested changes
Jun 29, 2022
dagardner-nv
approved these changes
Jun 30, 2022
@gpucibot merge |
ghost
pushed a commit
that referenced
this pull request
Jul 25, 2022
Similar set of changes found elsewhere to account for data dir relocations. Relates to #232 and #242 Authors: - Pete MacKinnon (https://github.com/pdmack) Approvers: - Christopher Harris (https://github.com/cwharris) - Michael Demoret (https://github.com/mdemoret-nv) - David Gardner (https://github.com/dagardner-nv) URL: #284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Looks like conda-build doesnt download LFS files regardless of what you do: conda/conda-build#1462. They have had a PR to fix this for a while it looks like: conda/conda-build#4318.
This PR just removes the files in
morpheus/data/**
from LFS. These files are small, downloaded automatically, and included inside of the conda package so they shouldnt be LFS.