Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Morpheus Data Files Out of LFS #242

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Fixes #240

Looks like conda-build doesnt download LFS files regardless of what you do: conda/conda-build#1462. They have had a PR to fix this for a while it looks like: conda/conda-build#4318.

This PR just removes the files in morpheus/data/** from LFS. These files are small, downloaded automatically, and included inside of the conda package so they shouldnt be LFS.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change 2 - In Progress labels Jun 29, 2022
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 29, 2022 16:49
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 29, 2022 16:49
@mdemoret-nv mdemoret-nv changed the title Mdd debug conda build Move Morpheus Data Files Out of LFS Jun 29, 2022
@dagardner-nv dagardner-nv self-requested a review June 30, 2022 04:23
@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@mdemoret-nv mdemoret-nv merged commit ac015d0 into nv-morpheus:branch-22.06 Jun 30, 2022
@mdemoret-nv mdemoret-nv deleted the mdd_debug-conda-build branch June 30, 2022 05:31
pdmack added a commit that referenced this pull request Jul 18, 2022
Similar set of changes found elsewhere to account for data dir relocations.
Relates to #232 and #242
ghost pushed a commit that referenced this pull request Jul 25, 2022
Similar set of changes found elsewhere to account for data dir relocations.
Relates to #232 and #242

Authors:
  - Pete MacKinnon (https://github.com/pdmack)

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Michael Demoret (https://github.com/mdemoret-nv)
  - David Gardner (https://github.com/dagardner-nv)

URL: #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pipeline-nlp fails between dropna and preprocess stages (22.06)
2 participants