Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Morpheus to Use SRF 22.06 #152

Merged
27 commits merged into from
Jun 21, 2022
Merged

Update Morpheus to Use SRF 22.06 #152

27 commits merged into from
Jun 21, 2022

Conversation

mdemoret-nv
Copy link
Contributor

This PR updates all references from Neo->SRF. It also updates the CMake build to allow building SRF from source again.

@mdemoret-nv mdemoret-nv added enhancement Additional functionality added to an existing feature breaking Breaking change 2 - In Progress labels Jun 9, 2022
@mdemoret-nv mdemoret-nv added feature request New feature or request and removed enhancement Additional functionality added to an existing feature labels Jun 9, 2022
@mdemoret-nv mdemoret-nv marked this pull request as ready for review June 13, 2022 23:48
@mdemoret-nv mdemoret-nv requested review from a team as code owners June 13, 2022 23:48
@cwharris
Copy link
Contributor

@mdemoret-nv any reason we're commenting out GenericTensor instead of just deleting it? (same question for any other commented-out code).

cwharris
cwharris approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I had some questions you might want to address.

drobison00
drobison00 reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, some comments.

Added quite a few nit pick comments that I think would improve clarity, consistency, and readability.

@mdemoret-nv
Copy link
Contributor Author

@mdemoret-nv any reason we're commenting out GenericTensor instead of just deleting it? (same question for any other commented-out code).

This code was copied verbatim from Neo to Morpheus. I have just removed it since it wont be needed anymore.

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 17, 2022 21:45
@dagardner-nv
Copy link
Contributor

rerun tests

@mdemoret-nv mdemoret-nv requested a review from drobison00 June 17, 2022 22:53
BartleyR
BartleyR approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@BartleyR BartleyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for DS

drobison00
drobison00 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 25f401f into nv-morpheus:branch-22.06 Jun 21, 2022
@cwharris cwharris mentioned this pull request Jun 23, 2022
Merged
@mdemoret-nv mdemoret-nv deleted the mdd_use-srf-22.06 branch June 28, 2022 22:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@BartleyR BartleyR BartleyR approved these changes

@drobison00 drobison00 drobison00 approved these changes

@raykallen raykallen raykallen approved these changes

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees
No one assigned
Labels
breaking Breaking change feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mdemoret-nv @cwharris @dagardner-nv @BartleyR @drobison00 @raykallen @pdmack