Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Morpheus CLI logged feature_columns don't match actual features #819

Closed
2 tasks done
dagardner-nv opened this issue Mar 29, 2023 · 0 comments · Fixed by #983
Closed
2 tasks done

[BUG]: Morpheus CLI logged feature_columns don't match actual features #819

dagardner-nv opened this issue Mar 29, 2023 · 0 comments · Fixed by #983
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

23.03

Which installation method(s) does this occur on?

Docker, Conda, Source

Describe the bug.

Not all pipelines set feature_columns in the pipeline config, specifically the ransomware_detection and abp_pcap_detection examples don't set these.

When we run these with their associated run.py script this isn't a problem, however using the equivalent CLI command the default features for the FIL pipeline are logged (the nvsmi features).

I think we have two options:

  1. Simply don't log the config.fil.feature_columns and config.ae.feature_columns.
  2. Re-work these examples to populated the config.

Personally I like option 1

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Mar 29, 2023
@dagardner-nv dagardner-nv self-assigned this Mar 29, 2023
@github-actions github-actions bot added the Needs Triage Need team to review and classify label Mar 29, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Jun 12, 2023
This was referenced Jun 13, 2023
Closed
Merged
@rapids-bot rapids-bot bot closed this as completed in #983 Jun 23, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 23, 2023
@dagardner-nv
Fix logging of wrong feature_columns in CLI and exception in auto-com…
5990f3a 
…plete (#983)

The CLI command for the FIL pipeline set a default value for `--columns_file` flag but some FIL pipelines like ransomeware didn't use this config property, causing the default columns file to be loaded and for the values to be logged to the terminal.

* Removed default values for `--columns_file` and `--labels-file` flags
* Removed redundant checks for null values if they were already being enforced by `required=True`
* Fix raised exception when using click auto-complete
* Misc pylint/flake8 errors

fixes #984
fixes #819

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)
  - Pete MacKinnon (https://github.com/pdmack)

URL: #983
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
2 participants
@dagardner-nv @jarmak-nv