Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC]: Build warnings from rabbitmq example #471

Closed
2 tasks done
dagardner-nv opened this issue Nov 16, 2022 · 0 comments · Fixed by #658
Closed
2 tasks done

[DOC]: Build warnings from rabbitmq example #471

dagardner-nv opened this issue Nov 16, 2022 · 0 comments · Fixed by #658
Assignees
@dagardner-nv
Labels
doc Improvements or additions to documentation

Comments

@dagardner-nv
Copy link
Contributor

How would you describe the priority of this documentation request

Low (would be nice)

Please provide a link or source to the relevant docs

examples/developer_guide/4_rabbitmq_cpp_stage

Describe the problems in the documentation

[133/249] Building C object _deps/rabbitmq-build/librabbitmq/CMakeFiles/rabbitmq.dir/amqp_connection.c.o
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c: In function 'amqp_handle_input':
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:267:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
  267 |       if (memcmp(raw_frame, "AMQP", 4) == 0) {
      |          ^
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:287:5: note: here
  287 |     case CONNECTION_STATE_HEADER: {
      |     ^~~~
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:287:35: warning: this statement may fall through [-Wimplicit-fallthrough=]
  287 |     case CONNECTION_STATE_HEADER: {
      |                                   ^
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:334:5: note: here
  334 |     case CONNECTION_STATE_BODY: {
      |     ^~~~
[134/249] Building C object _deps/rabbitmq-build/librabbitmq/CMakeFiles/rabbitmq-static.dir/amqp_connection.c.o
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c: In function 'amqp_handle_input':
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:267:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
  267 |       if (memcmp(raw_frame, "AMQP", 4) == 0) {
      |          ^
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:287:5: note: here
  287 |     case CONNECTION_STATE_HEADER: {
      |     ^~~~
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:287:35: warning: this statement may fall through [-Wimplicit-fallthrough=]
  287 |     case CONNECTION_STATE_HEADER: {
      |                                   ^
/home/dagardner/work/morpheus/.cache/cpm/rabbitmq/6b6fe482f87f4e156bcc5e8e9dd2e3a56a76ef12/librabbitmq/amqp_connection.c:334:5: note: here
  334 |     case CONNECTION_STATE_BODY: {
      |     ^~~~

(Optional) Propose a correction

Silence warnings just for building the librabbitmq dependency.
Alternately submit a patch to the project to fix the warnings.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the doc Improvements or additions to documentation label Nov 16, 2022
@dagardner-nv dagardner-nv self-assigned this Nov 16, 2022
@dagardner-nv dagardner-nv mentioned this issue Jan 31, 2023
Merged
@ghost ghost closed this as completed in #658 Feb 1, 2023
ghost pushed a commit that referenced this issue Feb 1, 2023
@dagardner-nv
Silence build warnings when building rabbitmq example (#658)
c733860 
* Track recent commit for rabbitmq, which resolved warnings coming from cmake. Unfortunately these fixes are unreleased (alanxz/rabbitmq-c#740) 
* Silence warnings coming from SimpleAmqpClient

fixes #471

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #658
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Feb 1, 2023
@dagardner-nv dagardner-nv mentioned this issue Feb 7, 2023
Closed
2 tasks
jjacobelli pushed a commit to jjacobelli/Morpheus that referenced this issue Mar 7, 2023
@dagardner-nv @jjacobelli
Silence build warnings when building rabbitmq example (nv-morpheus#658)
49c3a22 
* Track recent commit for rabbitmq, which resolved warnings coming from cmake. Unfortunately these fixes are unreleased (alanxz/rabbitmq-c#740) 
* Silence warnings coming from SimpleAmqpClient

fixes nv-morpheus#471

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: nv-morpheus#658
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Silence build warnings when building rabbitmq example dagardner-nv/Morpheus
1 participant
@dagardner-nv