Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Adopt newer version of Matx #317

Closed
dagardner-nv opened this issue Aug 4, 2022 · 0 comments · Fixed by #667
Closed

[FEA] Adopt newer version of Matx #317

dagardner-nv opened this issue Aug 4, 2022 · 0 comments · Fixed by #667
Assignees
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Aug 4, 2022

Is your feature request related to a problem? Please describe.
We are on the initial release v0.1.0, while the most recent release is v0.3.0
In the past we were blocked on upgrading due to dependency issues, but that is no longer the case.

Describe the solution you'd like
Adopt v0.3.0 using newer factory methods like make_tensor rather than the tensor_t constructors.

Additional context
I took a pass at it, and realized there was a bit more involved than I had time for at the time.

@dagardner-nv dagardner-nv added the feature request New feature or request label Aug 4, 2022
@jarmak-nv jarmak-nv moved this to Todo in Morpheus Boards Aug 5, 2022
@dagardner-nv dagardner-nv self-assigned this Jan 27, 2023
@rapids-bot rapids-bot bot closed this as completed in #667 Feb 22, 2023
rapids-bot bot pushed a commit that referenced this issue Feb 22, 2023
* Remove usage of `tensorShape_t` which was deprecated, and later removed.
* Replace usage of tensor constructor in favor of the recommended `make_tensor` helper method.
* Adds more C++ unittests
* RMMTensor marked as a public symbol so the C++ tests can use it
* Add `cuda-nvtx` package to CI driver build, needed for matx-0.3.0

Includes changes from PR #688
fixes #317

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #667
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Feb 22, 2023
jjacobelli pushed a commit to jjacobelli/Morpheus that referenced this issue Mar 7, 2023
* Remove usage of `tensorShape_t` which was deprecated, and later removed.
* Replace usage of tensor constructor in favor of the recommended `make_tensor` helper method.
* Adds more C++ unittests
* RMMTensor marked as a public symbol so the C++ tests can use it
* Add `cuda-nvtx` package to CI driver build, needed for matx-0.3.0

Includes changes from PR nv-morpheus#688
fixes nv-morpheus#317

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: nv-morpheus#667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant