[DOC] Add filter stage back to nlp_si_detection example once issue #83 is resolved #197
Assignees
Labels
doc
Improvements or additions to documentation
Comments
ghost
pushed a commit
that referenced
this issue
Jun 27, 2022
* Add a second monitor stage to report progress for the back-half of the pipeline * Increase threads to match number of stages * Change triton port to 8000 avoiding a warning about the grpc port * Add EdgeConnectors for derived classes of MultiMessage to MultiMessage * Remove filter stage from example #83 & #197 fixes #186 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #193
ghost
pushed a commit
that referenced
this issue
Aug 1, 2022
* `FilterDetectionStage` now optionally performs a copy of matching rows (now the default behavior), this resolves the performance issues discovered in #83 * Adds a `copy_ranges` method to `MultiMessage` which parallels the `get_slice` method except that it takes a full copy and is able to select multiple ranges from the table. * `MultiMessage` now inherits from `DerivedMultiMessage` which implements the curiously recurring template pattern. This allows the public versions of `get_slice` and `copy_ranges` to return a `std::shared_ptr<T>` which removes the need of implementing `get_slice` in multiple derived classes. * Adds new `TensorMemory` class which serves as the base class for `InferenceMemory` & `ResponseMemory`. * For `MultiInference` and `MultiResponce` this also copies the input and output tensors respectively. * Adds `copy_rows` method to `TensorObject` and `Tensor` classes. * Drive-by fix for `MultiMessage.get_meta_list` which was broken by our recent cudf upgrade, and never had a C++ impl (still doesn't but I added it to the binding). Fixes #83 Fixes #197 Fixes #217 Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #231
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Report incorrect documentation
#193 Removed the filter stage from this example as a work-around for #83.
Once that is resolved we should add the filter stage back in.
Location of incorrect documentation
examples/nlp_si_detection/README.mdThe text was updated successfully, but these errors were encountered: