Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Unittests fail during collection with pytest 8 #1484

Closed
2 tasks done
dagardner-nv opened this issue Jan 29, 2024 · 0 comments · Fixed by #1485
Closed
2 tasks done

[BUG]: Unittests fail during collection with pytest 8 #1484

dagardner-nv opened this issue Jan 29, 2024 · 0 comments · Fixed by #1485
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Source

Describe the bug.

pytest 8 was released yesterday, and causes our tests to fail during collection.

Minimum reproducible example

pytest

Relevant log output

Click here to see error details
2024-01-29T18:06:13.5391160Z platform linux -- Python 3.10.13, pytest-8.0.0, pluggy-1.4.0

2024-01-29T18:06:13.5395420Z benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)

2024-01-29T18:06:13.5400564Z rootdir: /__w/Morpheus/Morpheus/morpheus

2024-01-29T18:06:13.5401990Z configfile: pyproject.toml

2024-01-29T18:06:13.5403838Z plugins: benchmark-4.0.0, kafka-0.6.0, cov-4.1.0, asyncio-0.23.3

2024-01-29T18:06:13.5405622Z asyncio: mode=auto

2024-01-29T18:06:13.5406575Z collected 0 items

2024-01-29T18:06:13.5407774Z INTERNALERROR> Traceback (most recent call last):

2024-01-29T18:06:13.5411739Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 272, in wrap_session

2024-01-29T18:06:13.5415265Z INTERNALERROR>     session.exitstatus = doit(config, session) or 0

2024-01-29T18:06:13.5418946Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 325, in _main

2024-01-29T18:06:13.5422305Z INTERNALERROR>     config.hook.pytest_collection(session=session)

2024-01-29T18:06:13.5426069Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_hooks.py", line 501, in call

2024-01-29T18:06:13.5430084Z INTERNALERROR>     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)

2024-01-29T18:06:13.5434406Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_manager.py", line 119, in _hookexec

2024-01-29T18:06:13.5438334Z INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)

2024-01-29T18:06:13.5442569Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 138, in _multicall

2024-01-29T18:06:13.5446226Z INTERNALERROR>     raise exception.with_traceback(exception.traceback)

2024-01-29T18:06:13.5450199Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 121, in _multicall

2024-01-29T18:06:13.5454071Z INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]

2024-01-29T18:06:13.5458195Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/logging.py", line 783, in pytest_collection

2024-01-29T18:06:13.5461461Z INTERNALERROR>     return (yield)

2024-01-29T18:06:13.5464725Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 121, in _multicall

2024-01-29T18:06:13.5468599Z INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]

2024-01-29T18:06:13.5472763Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/warnings.py", line 118, in pytest_collection

2024-01-29T18:06:13.5476024Z INTERNALERROR>     return (yield)

2024-01-29T18:06:13.5479385Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 121, in _multicall

2024-01-29T18:06:13.5483233Z INTERNALERROR>     teardown.throw(exception)  # type: ignore[union-attr]

2024-01-29T18:06:13.5487538Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/config/init.py", line 1365, in pytest_collection

2024-01-29T18:06:13.5491009Z INTERNALERROR>     return (yield)

2024-01-29T18:06:13.5494248Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 102, in _multicall

2024-01-29T18:06:13.5497527Z INTERNALERROR>     res = hook_impl.function(*args)

2024-01-29T18:06:13.5501166Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 336, in pytest_collection

2024-01-29T18:06:13.5504411Z INTERNALERROR>     session.perform_collect()

2024-01-29T18:06:13.5507892Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 799, in perform_collect

2024-01-29T18:06:13.5511316Z INTERNALERROR>     self.items.extend(self.genitems(node))

2024-01-29T18:06:13.5514853Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 942, in genitems

2024-01-29T18:06:13.5518205Z INTERNALERROR>     yield from self.genitems(subnode)

2024-01-29T18:06:13.5521726Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 937, in genitems

2024-01-29T18:06:13.5525821Z INTERNALERROR>     rep, duplicate = self._collect_one_node(node, handle_dupes)

2024-01-29T18:06:13.5529925Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/main.py", line 825, in _collect_one_node

2024-01-29T18:06:13.5533599Z INTERNALERROR>     rep = collect_one_node(node)

2024-01-29T18:06:13.5537197Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/_pytest/runner.py", line 566, in collect_one_node

2024-01-29T18:06:13.5540819Z INTERNALERROR>     ihook.pytest_collectstart(collector=collector)

2024-01-29T18:06:13.5544522Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_hooks.py", line 501, in call

2024-01-29T18:06:13.5548493Z INTERNALERROR>     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)

2024-01-29T18:06:13.5552906Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_manager.py", line 119, in _hookexec

2024-01-29T18:06:13.5556890Z INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)

2024-01-29T18:06:13.5561148Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 138, in _multicall

2024-01-29T18:06:13.5564828Z INTERNALERROR>     raise exception.with_traceback(exception.traceback)

2024-01-29T18:06:13.5568785Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pluggy/_callers.py", line 102, in _multicall

2024-01-29T18:06:13.5572048Z INTERNALERROR>     res = hook_impl.function(*args)

2024-01-29T18:06:13.5576029Z INTERNALERROR>   File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/pytest_asyncio/plugin.py", line 626, in pytest_collectstart

2024-01-29T18:06:13.5579536Z INTERNALERROR>     pyobject = collector.obj

2024-01-29T18:06:13.5581838Z INTERNALERROR> AttributeError: 'Package' object has no attribute 'obj'

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jan 29, 2024
@dagardner-nv dagardner-nv mentioned this issue Jan 29, 2024
Merged
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Jan 29, 2024
@rapids-bot rapids-bot bot closed this as completed in #1485 Feb 1, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 1, 2024
@dagardner-nv
Pin pytest to <8 (#1485)
ff24174 
Closes #1484

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1485
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin pytest to <8 dagardner-nv/Morpheus
1 participant
@dagardner-nv