Skip to content

Commit

Permalink
Removing explicit driver install from CI runner (#877)
Browse files Browse the repository at this point in the history
This PR is follows the MRC PR: nv-morpheus/MRC#313 which removes the explicit dependency on `libnvidia-ml.so` which allows us to no longer need the driver installed in our CI runner.

This allows us to use the `gpu-v100-latest-1` tag to stay up to date with the CI images.

@jjacobelli for Viz

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #877
  • Loading branch information
mdemoret-nv authored Apr 13, 2023
1 parent 41e1a00 commit b2f58b7
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_pipe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
test:
name: Test
needs: [build]
runs-on: [self-hosted, linux, amd64, gpu-v100-525-1]
runs-on: [self-hosted, linux, amd64, gpu-v100-latest-1]
timeout-minutes: 60
container:
credentials:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
uses: ./.github/workflows/ci_pipe.yml
with:
run_check: ${{ startsWith(github.ref_name, 'pull-request/') }}
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-driver-230315
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230315
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-build-230413
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230413
secrets:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
11 changes: 7 additions & 4 deletions ci/runner/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ RUN CONDA_ALWAYS_YES=true /opt/conda/bin/mamba env create -n ${PROJ_NAME} -q --f
rm -rf /tmp/conda


# ============ driver ==================
FROM base as driver
# ============ build ==================
FROM base as build

# Add any build only dependencies here.

ARG CUDA_PKG_VER

Expand All @@ -62,15 +64,16 @@ RUN apt update && \
libcublas-dev-${CUDA_PKG_VER} \
libcufft-dev-${CUDA_PKG_VER} \
libcurand-dev-${CUDA_PKG_VER} \
libcusolver-dev-${CUDA_PKG_VER} \
libnvidia-compute-525 && \
libcusolver-dev-${CUDA_PKG_VER} && \
apt clean && \
rm -rf /var/lib/apt/lists/*


# ============ test ==================
FROM base as test

# Add any test only dependencies here.

ARG PROJ_NAME

RUN apt update && \
Expand Down
3 changes: 2 additions & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,10 @@
add_module_names = False # Remove namespaces from class/method signatures
myst_heading_anchors = 4 # Generate links for markdown headers
autodoc_mock_imports = [
"cudf", # Avoid loading GPU libraries during the documentation build
"morpheus.cli.commands", # Dont document the CLI in Sphinx
"tqdm",
"tensorrt",
"tqdm",
]

# Config numpydoc
Expand Down

0 comments on commit b2f58b7

Please sign in to comment.