Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxNodeComponent should set exceptions on the context #326

Merged
merged 6 commits into from
May 10, 2023
Merged

RxNodeComponent should set exceptions on the context #326

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a1aa8b
WIP: DO NOT MERGE
dagardner-nv May 9, 2023
32cdc8e
wip
dagardner-nv May 9, 2023
30dfbbd
Set the exception on the context so its handled propperly
dagardner-nv May 9, 2023
dbd9500
Revert "wip"
dagardner-nv May 9, 2023
892fdf8
Revert "WIP: DO NOT MERGE"
dagardner-nv May 9, 2023
c13d2ba
Update cpp/mrc/include/mrc/node/rx_node.hpp
dagardner-nv May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cpp/mrc/include/mrc/node/rx_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ class RxNodeComponent : public WritableProvider<InputT>, public WritableAcceptor
// Forward to the writable edge
this->get_writable_edge()->await_write(std::move(message));
},
[this](std::exception_ptr ptr) {
runnable::Context::get_runtime_context().set_exception(std::move(ptr));
},
[this]() {
// On completion, release connections
WritableAcceptor<OutputT>::release_edge_connection();
Expand Down