Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): columns select is obscured #2714

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Jevin0
Copy link

@Jevin0 Jevin0 commented Nov 21, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

before:
image

after:
image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

I don't reproduce this on https://ui.nuxt.com/components/table#columns 🤔
CleanShot 2024-11-21 at 10.43.43@2x.png

@Jevin0
Copy link
Author

Jevin0 commented Nov 21, 2024

I don't reproduce this on https://ui.nuxt.com/components/table#columns 🤔 CleanShot 2024-11-21 at 10.43.43@2x.png

Try unchecking all five options. It will be difficult to check them back later.

Copy link
Member

benjamincanac commented Nov 21, 2024

Oh I see, maybe we should add a min-height on the Table instead then?

@Jevin0
Copy link
Author

Jevin0 commented Nov 21, 2024

Oh I see, maybe we should add a min-height on the Table instead then?哦,我明白了,也许我们应该在桌子上添加一个min-height

If min-height is set, there will be some blank space after deselecting all and then closing the drop-down. Will it look ugly?

@Jevin0
Copy link
Author

Jevin0 commented Nov 21, 2024

image

This is the effect after trying to set min-height. If you think it's okay, I will modify it like this

Copy link
Member

Yeah I think it's fine because removing the overflow-hidden might break the display on mobile!

@Jevin0
Copy link
Author

Jevin0 commented Nov 21, 2024

@benjamincanac done

@benjamincanac benjamincanac changed the title docs(table): seleteMenu is obscured docs(table): columns select is obscured Nov 21, 2024
@benjamincanac benjamincanac merged commit dbd2aed into nuxt:dev Nov 21, 2024
1 check passed
@benjamincanac
Copy link
Member

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants