Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unplugin): add declared types for #build/app.config #2625

Draft
wants to merge 6 commits into
base: v3
Choose a base branch
from

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This resolves type checking issues associated with using #build/app.config in a Vue project. There are still additional type issues to resolve:

  • #imports (useAppConfig)
  • #vue-router (this is no longer needed - it can be vue-router)
  • browser/dom which is probably a straightforward change to vue tsconfig

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Nov 12, 2024
Copy link

pkg-pr-new bot commented Nov 12, 2024

npm i https://pkg.pr.new/@nuxt/ui@2625

commit: 101f6d6

@benjamincanac benjamincanac added the v3 #1289 label Nov 13, 2024
@danielroe danielroe marked this pull request as draft November 17, 2024 15:59
@benjamincanac benjamincanac force-pushed the v3 branch 2 times, most recently from aa74a4f to 87234cb Compare February 4, 2025 15:31
Copy link
Contributor

nuxthub-admin bot commented Feb 19, 2025

βœ… Deployed ui3

Deployed ui3 101f6d6 to preview

πŸ”— fix-app-config-types.ui-6q2.pages.dev
πŸ“Œ 669002e9.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2025

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 101f6d6
Status:Β βœ…Β  Deploy successful!
Preview URL: https://669002e9.ui-6q2.pages.dev
Branch Preview URL: https://fix-app-config-types.ui-6q2.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants