Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): include components runtime dir in build output #10046

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 11, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

server-component in the runtime dir was not being generated/included in the final bundle. this issue was caught with vite-ecosystem-ci1: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3889861604/jobs/6638482274

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jan 11, 2023
@danielroe danielroe self-assigned this Jan 11, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 11, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit 698a310 into main Jan 11, 2023
@danielroe danielroe deleted the fix/components-runtime branch January 11, 2023 20:51
@SirMishaa
Copy link
Contributor

Hello @danielroe, thank you for this fix, we're going to use Nuxt at work and this is important for us.

Do you have an estimate on when it will be live on the next version of Nuxt? We have a pretty big mob party in two weeks and having this particular fix would be super cool.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants