fix: update package.json files #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Mar 28, 2024
packages/eslint-config/package.json
Outdated
Comment on lines
11
to
20
| "exports": { | ||
| ".": { | ||
| "import": "./dist/legacy.mjs", | ||
| "require": "./dist/legacy.cjs" | ||
| }, | ||
| "./flat": { | ||
| "types": "./dist/flat.d.ts", | ||
| "import": "./dist/flat.mjs", | ||
| "require": "./dist/flat.cjs" | ||
| }, | ||
| "./legacy": { | ||
| "types": "./dist/legacy.d.ts", | ||
| "import": "./dist/legacy.mjs", | ||
| "require": "./dist/legacy.cjs" |
There was a problem hiding this comment.
Legacy first is intentionally here to keep backward compatibility (also the legacy format can't load sub modules)
There was a problem hiding this comment.
Are we planning to eventually change it (e.g. when ESLint v9 gets out of RC)? Flat config will be the 'new default' at that stage.
There was a problem hiding this comment.
No, as I said, it's not compatible with the legacy format, so we have to keep the default export to the legacy - at some point, we could emit a warning message and ask to change over, but not right now as the ecosystem is still catching up. With the nuxt module, users don't usually need to care about this anyway
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.