-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module): allow specifying version alongside module name #702
Conversation
commit: |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage ? 14.23%
=======================================
Files ? 65
Lines ? 3133
Branches ? 94
=======================================
Hits ? 446
Misses ? 2656
Partials ? 31 β View full report in Codecov by Sentry. |
@danielroe could you help with the failing build-head actions? by the logs it looks like something related to girhub configuration, but i can understand more than that. |
you can ignore that! i need to fix the action so it works on forks too the only thing it does is compare bundle sizes between main branch and this pr |
@danielroe gotcha, i can help with that too, i've found this actions/checkout#551 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
particularly thank you for the unit test...
fix #697 #701
π Linked issue
resolves #697, resolves #701
β Type of change
π Description
This PR enhance the
nuxi module add
but allowing it to find a Nuxt Module when a version is speficied.Without this PR:
![Screenshot From 2025-01-25 01-32-15](https://private-user-images.githubusercontent.com/6757777/406641354-c876179c-7bb9-43dc-878f-217b83947a09.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjA5NTksIm5iZiI6MTczOTU2MDY1OSwicGF0aCI6Ii82NzU3Nzc3LzQwNjY0MTM1NC1jODc2MTc5Yy03YmI5LTQzZGMtODc4Zi0yMTdiODM5NDdhMDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTkxNzM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmFiNjZkYjcwZGNiOTMzMTkzYjc2Y2YwMmIzOWU5MWExYWY0MjUzYjhiMTQ0OWViNTc4NTllZDgzMjZjOGQ0NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.8j4jnTIcf6vE6fhGkgYdosltGQ656iMwrVYRLcPodvo)
With this PR:
![Screenshot From 2025-01-25 01-33-07](https://private-user-images.githubusercontent.com/6757777/406641365-ae26eff8-5732-4776-b206-195d19eb5c65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjA5NTksIm5iZiI6MTczOTU2MDY1OSwicGF0aCI6Ii82NzU3Nzc3LzQwNjY0MTM2NS1hZTI2ZWZmOC01NzMyLTQ3NzYtYjIwNi0xOTVkMTllYjVjNjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTkxNzM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWFmMjE3Yjg4OGVjZjkxYmM2MDIwNDdlNDFlYjAzYjc3MGNlOThkZmVjOGQzZjZkMjAyMGQ4MjMxN2Y5NzczMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.1H8Ui6JAae8b1RTevWYo1LNArp5ZlmgodsOma3Vn5tw)