Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): allow specifying version alongside module name #702

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

schirrel
Copy link
Contributor

@schirrel schirrel commented Jan 25, 2025

fix #697 #701

πŸ”— Linked issue

resolves #697, resolves #701

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR enhance the nuxi module add but allowing it to find a Nuxt Module when a version is speficied.

Without this PR:
Screenshot From 2025-01-25 01-32-15

With this PR:
Screenshot From 2025-01-25 01-33-07

@schirrel schirrel requested a review from danielroe as a code owner January 25, 2025 05:34
Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@702
npm i https://pkg.pr.new/@nuxt/cli@702
npm i https://pkg.pr.new/nuxi@702

commit: 3208e75

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Please upload report for BASE (main@1199a3b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage        ?   14.23%           
=======================================
  Files           ?       65           
  Lines           ?     3133           
  Branches        ?       94           
=======================================
  Hits            ?      446           
  Misses          ?     2656           
  Partials        ?       31           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@schirrel schirrel changed the title fix(module): check module name matches pkgName if it has pkgVersion fix(module): add module with version Jan 25, 2025
@schirrel schirrel closed this Jan 25, 2025
@schirrel schirrel reopened this Jan 25, 2025
@schirrel
Copy link
Contributor Author

@danielroe could you help with the failing build-head actions? by the logs it looks like something related to girhub configuration, but i can understand more than that.
Thanks!

@danielroe
Copy link
Member

danielroe commented Jan 25, 2025

you can ignore that! i need to fix the action so it works on forks too

the only thing it does is compare bundle sizes between main branch and this pr

@schirrel
Copy link
Contributor Author

@danielroe gotcha, i can help with that too, i've found this actions/checkout#551
I will open an PR adding repository: ${{ github.event.pull_request.head.repo.full_name }} to check if this continue to work

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

particularly thank you for the unit test...

@danielroe danielroe merged commit ee0f67e into nuxt:main Jan 26, 2025
8 of 9 checks passed
@danielroe danielroe changed the title fix(module): add module with version fix(module): allow specifying version alongside module name Jan 26, 2025
This was referenced Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants