Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add support for nuxt 3/nuxt bridge #74

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Mar 8, 2023

This PR enables this module to work for Nuxt Bridge & Nuxt 3.
Resoles #63

🔥 Notable changes

  • Uses @nuxt/module-builder to build module
  • Refactor structure using @nuxt/kit

@ricardogobbosouza ricardogobbosouza changed the title feat: support nuxt 3 refactor!: add support for nuxt 3/nuxt bridge Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #74 (795b14a) into main (ecbd1d9) will decrease coverage by 20.00%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##              main      #74       +/-   ##
============================================
- Coverage   100.00%   80.00%   -20.00%     
============================================
  Files            3        2        -1     
  Lines           22       70       +48     
  Branches         2        7        +5     
============================================
+ Hits            22       56       +34     
- Misses           0       14       +14     
Impacted Files Coverage Δ
src/module.ts 78.46% <78.46%> (ø)
playground/nuxt.config.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ricardogobbosouza ricardogobbosouza merged commit 3d0c3a9 into main Mar 8, 2023
@ricardogobbosouza ricardogobbosouza deleted the nuxt3 branch March 8, 2023 16:59
@MartinX3
Copy link

MartinX3 commented Mar 8, 2023

@ricardogobbosouza
With 5.0.0 I get the following error in pnpm:

└─┬ @nuxtjs/stylelint-module 5.0.0
  ├─┬ vite-plugin-stylelint 4.2.0
  │ └── ✕ missing peer vite@"^2.0.0 || ^3.0.0 || ^4.0.0"
  └─┬ stylelint-webpack-plugin 4.1.0
    └── ✕ unmet peer webpack@^5.0.0: found 4.46.0
Peer dependencies that should be installed:
  vite@"^2.0.0 || ^3.0.0 || ^4.0.0"

I'm using nuxt 2 with nuxt bridge, which can't use webpack 5.
Also in my case I can't use vite, because vuetify 2 doesn't support it without complex workarounds.

@ricardogobbosouza
Copy link
Collaborator Author

Hi @MartinX3
Could it open a issue with your settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants