Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: status code handling #148

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

nuxencs
Copy link
Owner

@nuxencs nuxencs commented Oct 4, 2024

Refactors the whole handling of status codes by assigning each a specific message to reduce redundancy and make changes simpler going forward. This should also improve the switch logic for CheckCandidates.

@nuxencs nuxencs added Area: Release Processing Related to release processing Area: Logging Related to the logging Type: Refactor Refactoring of code Area: Torrents Related to the torrent handling Area: Notifications Related to notifications labels Oct 4, 2024
@nuxencs nuxencs marked this pull request as ready for review October 4, 2024 22:45
internal/domain/http.go Outdated Show resolved Hide resolved
internal/http/processor.go Show resolved Hide resolved
internal/http/processor.go Outdated Show resolved Hide resolved
internal/http/processor.go Outdated Show resolved Hide resolved
internal/notification/message_builder.go Outdated Show resolved Hide resolved
@nuxencs nuxencs requested review from zze0s and removed request for zze0s October 10, 2024 16:18
@nuxencs nuxencs force-pushed the refactor/status-code-handling branch from 548ff8a to 53134c1 Compare October 10, 2024 16:57
@nuxencs nuxencs merged commit 25c18d8 into develop Oct 10, 2024
12 checks passed
@nuxencs nuxencs deleted the refactor/status-code-handling branch October 10, 2024 17:01
@nuxencs nuxencs added this to the v0.11.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging Related to the logging Area: Notifications Related to notifications Area: Release Processing Related to release processing Area: Torrents Related to the torrent handling Type: Refactor Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants