Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement @forceDelete and @restore directives #941

Merged
merged 27 commits into from
Sep 3, 2019
Merged

Implement @forceDelete and @restore directives #941

merged 27 commits into from
Sep 3, 2019

Conversation

lorado
Copy link
Collaborator

@lorado lorado commented Aug 30, 2019

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated the changelog

Related Issue/Intent

As my work on #937 seems to be welcome, I directly implemented @forceDelete and @restore directive

Resolves #938

Changes

Add new directives:

  • @forceDelete to force delete models
  • @restore to restore soft deleted models

I actually forked @delete directive and used instead of delete, forceDelete/restore. So they are pretty similar and supports same features (global ID and modal directive-argument).

Breaking changes

There are no breaking changes.

@lorado
Copy link
Collaborator Author

lorado commented Aug 30, 2019

I hope you are fine with the refactoring...

To complete these PR I have to wait for #937. I would like to build up the documentation chapter Soft Deleting.

@spawnia spawnia added the enhancement A feature or improvement label Sep 2, 2019
@lorado lorado requested a review from spawnia September 2, 2019 23:54
Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorado for the great collaboration on this PR.

@lorado lorado merged commit b30ef88 into nuwave:master Sep 3, 2019
@lorado lorado deleted the implement-restore-and-forceDelete branch September 3, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend support for soft delete - @restore and @forceDelete directives?
2 participants